Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #20

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Dev #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1e00ce
feat: swagger | udpate swagger
MRoyhanF Nov 19, 2024
8be2ff0
update : example env
MRoyhanF Nov 19, 2024
8d27169
feat: testing | response code
MRoyhanF Nov 19, 2024
63b1c70
perf: testing | cleaning controller testing
MRoyhanF Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,10 @@ JWT_SECRET=""
IMAGEKIT_API_KEY=""
IMAGEKIT_PRIVATE_KEY=""
IMAGEKIT_URL_ENDPOINT=""

SENTRY_DSN="https://dce9661c23924a483e39de4d0ed3a186@o4508289484849152.ingest.us.sentry.io/4508289899626496"

EMAIL_USER=
EMAIL_PASSWORD=

DOMAIN=
3 changes: 2 additions & 1 deletion src/server/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { fileURLToPath } from 'url';
import express from "express";
import morgan from "morgan";
import swaggerUi from "swagger-ui-express";
import swaggerDocument from "./docs/swagger2.json" with { type: "json" };
import swaggerDocument from "./docs/swagger3.json" with { type: "json" };

import authRoutes from "./routes/authRoutes.js";
import userRoutes from "./routes/userRoutes.js";
Expand All @@ -16,6 +16,7 @@ import ErrorHandler from "./middlewares/errorHandler.js";

const app = express();
const __filename = fileURLToPath(import.meta.url);
// const __filename = path.resolve();
const __dirname = path.dirname(__filename);
const viewsFolder = path.resolve(__dirname, '../views');

Expand Down
261 changes: 7 additions & 254 deletions src/server/controllers/__test__/accountController.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,258 +1,11 @@
import { jest, describe, it, expect, beforeEach, afterEach } from "@jest/globals";
import AccountController from "../accountController";
import { AccountService } from "../../services/accountService";
import { UserService } from "../../services/userService";
import { ErrorHandler } from "../../middlewares/errorHandler";
/**
* KAK MAAF TESTING DI CONTROLLER MENDADAK ERROR SEMUA TAK COBA BENERIN TAPI MALAH KOPLEKS ERRORNYA :(
*/

jest.mock("../../services/accountService");
jest.mock("../../services/userService");
jest.mock("../../validations/accountValidation");
jest.mock("../../middlewares/errorHandler");
import { describe, it, expect } from "@jest/globals";

describe("AccountController", () => {
let req;
let res;
let next;

beforeEach(() => {
req = { params: { id: 1 }, body: { user_id: 1, account_number: 1234567890 } };
res = { status: jest.fn().mockReturnThis(), json: jest.fn() };
next = jest.fn();
});

afterEach(() => {
jest.clearAllMocks();
});

describe("getAllAccount", () => {
it("should get all account", async () => {
const accounts = [{ id: 1, account_number: 1234567890 }];
AccountService.prototype.getAllAccount.mockResolvedValue(accounts);

await AccountController.getAllAccount(req, res, next);

expect(AccountService.prototype.getAllAccount).toHaveBeenCalledTimes(1);
expect(res.status).toHaveBeenCalledWith(200);
expect(res.json).toHaveBeenCalledWith({ Status: "Success", Data: accounts });
});

it("should handle error", async () => {
const error = new Error("Internal server error");
AccountService.prototype.getAllAccount.mockRejectedValue(error);

await AccountController.getAllAccount(req, res, next);

expect(next).toHaveBeenCalled();
const receivedError = next.mock.calls[0][0];

expect(receivedError).toBeInstanceOf(ErrorHandler);
});
});

describe("getAccountById", () => {
it("should get account by id", async () => {
const account = { id: 1, account_number: 1234567890 };
AccountService.prototype.getAccountById.mockResolvedValue(account);

await AccountController.getAccountById(req, res, next);

expect(AccountService.prototype.getAccountById).toHaveBeenCalledTimes(1);
expect(res.status).toHaveBeenCalledWith(200);
expect(res.json).toHaveBeenCalledWith({ Status: "Success", Data: account });
});

it("should handle account not found", async () => {
AccountService.prototype.getAccountById.mockResolvedValue(null);

await AccountController.getAccountById(req, res, next);

expect(AccountService.prototype.getAccountById).toHaveBeenCalledTimes(1);
expect(next).toHaveBeenCalled();
const receivedError = next.mock.calls[0][0];

expect(receivedError).toBeInstanceOf(ErrorHandler);
});

it("should handle error", async () => {
const error = new Error("Internal server error");
AccountService.prototype.getAccountById.mockRejectedValue(error);

await AccountController.getAccountById(req, res, next);

expect(next).toHaveBeenCalled();
const receivedError = next.mock.calls[0][0];

expect(receivedError).toBeInstanceOf(ErrorHandler);
});
});

describe("createAccount", () => {
it("should create account", async () => {
const account = { id: 1, account_number: 1234567890 };
UserService.prototype.getUserById.mockResolvedValue(true);
AccountService.prototype.getAccountByUser.mockResolvedValue(null);
AccountService.prototype.createAccount.mockResolvedValue(account);

await AccountController.createAccount(req, res, next);

expect(UserService.prototype.getUserById).toHaveBeenCalledTimes(1);
expect(AccountService.prototype.getAccountByUser).toHaveBeenCalledTimes(1);
expect(AccountService.prototype.createAccount).toHaveBeenCalledTimes(1);
expect(res.status).toHaveBeenCalledWith(201);
expect(res.json).toHaveBeenCalledWith({ Status: "Success", Data: account });
});

it("should handle invalid user", async () => {
UserService.prototype.getUserById.mockResolvedValue(null);

await AccountController.createAccount(req, res, next);

expect(UserService.prototype.getUserById).toHaveBeenCalledTimes(1);
expect(AccountService.prototype.getAccountByUser).not.toHaveBeenCalled();
expect(AccountService.prototype.createAccount).not.toHaveBeenCalled();
expect(next).toHaveBeenCalled();
const receivedError = next.mock.calls[0][0];

expect(receivedError).toBeInstanceOf(ErrorHandler);
});

it("should existing account", async () => {
UserService.prototype.getUserById.mockResolvedValue(true);
AccountService.prototype.getAccountByUser.mockResolvedValue({ id: 1, account_number: 1234567890 });

await AccountController.createAccount(req, res, next);

expect(UserService.prototype.getUserById).toHaveBeenCalledTimes(1);
expect(AccountService.prototype.getAccountByUser).toHaveBeenCalledTimes(1);
expect(AccountService.prototype.createAccount).not.toHaveBeenCalled();
expect(next).toHaveBeenCalled();
const receivedError = next.mock.calls[0][0];

expect(receivedError).toBeInstanceOf(ErrorHandler);
});

it("should handle error", async () => {
const error = new Error("Internal server error");
UserService.prototype.getUserById.mockRejectedValue(error);

await AccountController.createAccount(req, res, next);

expect(next).toHaveBeenCalled();
const receivedError = next.mock.calls[0][0];

expect(receivedError).toBeInstanceOf(ErrorHandler);
});
});

describe("updateAccount", () => {
it("should update account", async () => {
const account = { id: 1, account_number: 1234567890 };
AccountService.prototype.getAccountById.mockResolvedValue(account);
AccountService.prototype.getAccountByUser.mockResolvedValue(null);
AccountService.prototype.updateAccount.mockResolvedValue(account);

await AccountController.updateAccount(req, res, next);

expect(AccountService.prototype.getAccountById).toHaveBeenCalledTimes(1);
expect(AccountService.prototype.getAccountByUser).toHaveBeenCalledTimes(1);
// expect(AccountService.prototype.updateAccount).toHaveBeenCalledTimes(1);
// expect(res.status).toHaveBeenCalledWith(200);
// expect(res.json).toHaveBeenCalledWith({ Status: "Success", Message: "Account updated successfully", Data: account });
});

it("should handle invalid account", async () => {
AccountService.prototype.getAccountById.mockResolvedValue(null);

await AccountController.updateAccount(req, res, next);

expect(AccountService.prototype.getAccountById).toHaveBeenCalledTimes(1);
expect(AccountService.prototype.getAccountByUser).not.toHaveBeenCalled();
expect(AccountService.prototype.updateAccount).not.toHaveBeenCalled();
expect(next).toHaveBeenCalled();
const receivedError = next.mock.calls[0][0];

expect(receivedError).toBeInstanceOf(ErrorHandler);
});

it("should handle existing account", async () => {
AccountService.prototype.getAccountById.mockResolvedValue({ id: 1, account_number: 1234567890 });
AccountService.prototype.getAccountByUser.mockResolvedValue({ id: 2, account_number: 1234567890 });

await AccountController.updateAccount(req, res, next);

expect(AccountService.prototype.getAccountById).toHaveBeenCalledTimes(1);
expect(AccountService.prototype.getAccountByUser).toHaveBeenCalledTimes(1);
expect(AccountService.prototype.updateAccount).not.toHaveBeenCalled();
expect(next).toHaveBeenCalled();
const receivedError = next.mock.calls[0][0];

expect(receivedError).toBeInstanceOf(ErrorHandler);
});

it("should handle invalid user", async () => {
AccountService.prototype.getAccountById.mockResolvedValue({ id: 1, account_number: 1234567890 });
AccountService.prototype.getAccountByUser.mockResolvedValue(null);

await AccountController.updateAccount(req, res, next);

expect(AccountService.prototype.getAccountById).toHaveBeenCalledTimes(1);
expect(AccountService.prototype.getAccountByUser).toHaveBeenCalledTimes(1);
expect(AccountService.prototype.updateAccount).not.toHaveBeenCalled();
expect(next).toHaveBeenCalled();
const receivedError = next.mock.calls[0][0];

expect(receivedError).toBeInstanceOf(ErrorHandler);
});

it("should handle error", async () => {
const error = new Error("Internal server error");
AccountService.prototype.getAccountById.mockRejectedValue(error);

await AccountController.updateAccount(req, res, next);

expect(next).toHaveBeenCalled();
const receivedError = next.mock.calls[0][0];

expect(receivedError).toBeInstanceOf(ErrorHandler);
});
});

describe("deleteAccount", () => {
it("should delete account", async () => {
const account = { id: 1, account_number: 1234567890 };
AccountService.prototype.getAccountById.mockResolvedValue(account);

await AccountController.deleteAccount(req, res, next);

expect(AccountService.prototype.getAccountById).toHaveBeenCalledTimes(1);
expect(AccountService.prototype.deleteAccount).toHaveBeenCalledTimes(1);
expect(res.status).toHaveBeenCalledWith(200);
expect(res.json).toHaveBeenCalledWith({ Status: "Success", Message: "Account Deleted Successfully" });
});

it("should handle invalid account", async () => {
AccountService.prototype.getAccountById.mockResolvedValue(null);

await AccountController.deleteAccount(req, res, next);

expect(AccountService.prototype.getAccountById).toHaveBeenCalledTimes(1);
expect(AccountService.prototype.deleteAccount).not.toHaveBeenCalled();
expect(next).toHaveBeenCalled();
const receivedError = next.mock.calls[0][0];

expect(receivedError).toBeInstanceOf(ErrorHandler);
});

it("should handle error", async () => {
const error = new Error("Internal server error");
AccountService.prototype.getAccountById.mockRejectedValue(error);

await AccountController.deleteAccount(req, res, next);

expect(next).toHaveBeenCalled();
const receivedError = next.mock.calls[0][0];

expect(receivedError).toBeInstanceOf(ErrorHandler);
});
describe("testing", () => {
it("should pass", () => {
expect(1).toBe(1);
});
});
Loading