First nav action proxy draft #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marioney can you check to approve and merge this pull request? |
|
Actually I don't know why do we need a nav2 action proxy in the tooling package? Being that this PR is from Nov 2020 it may be now outdated. @jginesclavero can you comment on this, was this replaced by the mros wrapper or is it a different issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @marioney @chcorbato !
I have developed a nav action wrapper. Currently, the wrapper only recives the action from the Patrol mission node and send it to the nav2 system. When the action sended to the nav2 systems finish, the wrapper notifies it to the Patrol mission node.
Is it the behaviour that you expected?