Fix rssa type check error: word size mismatch#183
Merged
Conversation
Compiling with `-type-check true` was previously throwing an error for RSSA type checking. The problem was a mismatch between word sizes in the generated code for read barrier fast paths. The generated code used `WordSize.shiftArg` for a mask on an object header. This just needed to be changed to `WordSize.objptrHeader()`. I cleaned up the code a little, too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling with
-type-check truewas previously throwing an error for RSSA type checking. The problem was a mismatch between word sizes in the generated code for read barrier fast paths. The generated code usedWordSize.shiftArgfor a mask on an object header. This just needed to be changed toWordSize.objptrHeader().I cleaned up the code a little, too.