Add Foxe Basin Throughflow #146
Conversation
There was a problem hiding this comment.
This looks great to me. I won't do separate testing of this change since testing of the previous 2 PRs on shipping routes was time consuming and I don't anticipate trouble but let me know if you would like to see a mesh and it's worth several more hours' work.
|
@xylar Thanks for the fast turnaround. From my side, no need to see a WC14 mesh with this change, since it's almost open in #145 anyhow. It's also pretty obvious in EC30to60 what the impact would be. So I'm fine with proceeding to WC14 r03, which I believe is the last revision for E3SM V2, pending the approval of @milenaveneziani to this PR. |
xylar
changed the title
TestingIn the end, I felt like the time it would take to test this now and make sure it works as expected would potentially save quite a bit more hassle down the road. EC30to60With Foxe Throughflow and Shipping Routes: Without either: WC14to60With Foxe Throughflow and Shipping Routes: Without either: |
|
oh I missed this PR entirely yesterday! Thanks @proteanplanet for putting this in and @xylar for testing. |
|
@milenaveneziani, thanks for reviewing. A rebase shouldn't be necessary. That's convenient for looking at the diffs in the PR but makes no difference for the final state of the repo. |
New Mesh: WC14to60kmL60E3SMv2r03 #628 Design discussion Water Cycle mesh, 14km high resolution region: MPAS North America and Arctic Focused Water Cycle mesh for E3SM version 2, with a focused 14-km resolution around North America and 60 vertical levels This iteration of the WC14 mesh is with shipping tracks (MPAS-Dev/geometric_features#145) and the Foxe Basin Throughflow (MPAS-Dev/geometric_features#146) open in the Arctic.
New Mesh: WC14to60kmL60E3SMv2r03 #628 Design discussion Water Cycle mesh, 14km high resolution region: MPAS North America and Arctic Focused Water Cycle mesh for E3SM version 2, with a focused 14-km resolution around North America and 60 vertical levels This iteration of the WC14 mesh is with shipping tracks (MPAS-Dev/geometric_features#145) and the Foxe Basin Throughflow (MPAS-Dev/geometric_features#146) open in the Arctic.
This pull request is at the suggestion of @milenaveneziani to include the Foxe Basin Through Flow in addition to the Arctic ship routes for WC14 r03, and is upstream of the Arctic Shipping PR . Transect added in this PR is indicated in red at the bottom of this map:
and is also available in KML here:
Foxe_Basin_Through_Flow.kml.zip
Please include @milenaveneziani in the review list to check that this is what she was requesting.