E3SM issue4152 bugfix #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch was tested in MPAS-O nightly regression suite, using
For E3SM testing, baselines were generated using commit The following tests that do not check for BFB passed. These tests started with E3SM hash The following tests that do not check for BFB passed. These tests started with E3SM hash |
|
@jonbob Just making you aware, since you created E3SM-Project/E3SM#4152 . Also, if there are any other E3SM BFB tests that failed that you would like me to test, just let me know. |
philipwjones
approved these changes
Mar 14, 2021
mark-petersen
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
Looks great! Thanks @mattdturner for your work here. I also tested with the nightly regression suite, verified that it is bfb with intel 19.0 optimized against bcde86f (before split explicit update).
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Mar 16, 2021
Update mpas-source: split explicit bugfix Brings in a new mpas-source submodule with changes only to the ocean core. It reverts a subset of the changes introduced in #4146 that caused non-BFB results for a few of the tests in E3SM. See MPAS-Dev/MPAS-Model#826 Fixes #4152 [non-BFB] for intel tests using the oECv3 mesh
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Mar 17, 2021
Update mpas-source: split explicit bugfix Brings in a new mpas-source submodule with changes only to the ocean core. It reverts a subset of the changes introduced in #4146 that caused non-BFB results for a few of the tests in E3SM. See MPAS-Dev/MPAS-Model#826 Fixes #4152 [non-BFB] for intel tests using the oECv3 mesh
mark-petersen
pushed a commit
to mark-petersen/MPAS-Model
that referenced
this pull request
Apr 12, 2021
…n/develop This PR reverts a subset of the changes introduced in MPAS-Dev#781 that caused non-BFB results for a few of the tests in E3SM. See discussion E3SM-Project/E3SM#4152 for more information. Changes include: - No longer use ocn_mesh in ocn_time_integration_split_init. This routine is run before ocn_meshCreate is run, so the variables in ocn_mesh would be undefined. I'm not sure why previous testing didn't catch this. - Revert one of the uTemp calculations to the old array syntax notation
vanroekel
pushed a commit
to vanroekel/MPAS-Model
that referenced
this pull request
Sep 20, 2021
…n/develop This PR reverts a subset of the changes introduced in MPAS-Dev#781 that caused non-BFB results for a few of the tests in E3SM. See discussion E3SM-Project/E3SM#4152 for more information. Changes include: - No longer use ocn_mesh in ocn_time_integration_split_init. This routine is run before ocn_meshCreate is run, so the variables in ocn_mesh would be undefined. I'm not sure why previous testing didn't catch this. - Revert one of the uTemp calculations to the old array syntax notation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts a subset of the changes introduced in #781 that caused non-BFB results for a few of the tests in E3SM.
See discussion E3SM-Project/E3SM#4152 for more information.
Changes include:
ocn_meshinocn_time_integration_split_init. This routine is run beforeocn_meshCreateis run, so the variables inocn_meshwould be undefined. I'm not sure why previous testing didn't catch this.uTempcalculations to the old array syntax notationNOTE: This PR will be non-BFB in E3SM