Skip to content

Changes to CVMix forcing and interface #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: ocean/develop
Choose a base branch
from

Conversation

vanroekel
Copy link
Contributor

This changes the amount of shortwave radiation in the boundary layer
which decreases vertical resolution sensitivity.

It also removes the shear instability driven mixing scheme from
operating in the boundary layer to reduce grid scale noise.

@vanroekel
Copy link
Contributor Author

@mark-petersen this is a modification for CVMix. In E3SM testing it improves boundary layer depths and also reduces (but doesn't fix) sensitivity to moving from 60-64 layers.

I have not run the nightly yet, will try to do so soon.

This changes the amount of shortwave radiation in the boundary layer
which decreases vertical resolution sensitivity.

It also removes the shear instability driven mixing scheme from
operating in the boundary layer to reduce grid scale noise.
@mark-petersen
Copy link
Contributor

Rebased, tested on grizzly with gnu and intel 19, debug and optimized. Passes nightly regression suite.

@vanroekel
Copy link
Contributor Author

@mark-petersen thanks for rebasing and testing!

One note, I just found a cvmix related bug that I'd like to add here. Please wait on merging this one until I can test that fix.

@mark-petersen
Copy link
Contributor

No problem. I still need to carefully read through the code on all these, and will double-check with you before merging.

@vanroekel vanroekel marked this pull request as draft September 10, 2020 20:24
@mark-petersen
Copy link
Contributor

@vanroekel, I'm pinging everyone on ocean PRs, as the queue is starting to move. What is the status of this one? We can still hold it as a draft if you want to postpone.

@vanroekel
Copy link
Contributor Author

@mark-petersen I'm testing these changes again, but with an updated version. So let's leave this in draft for a bit longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants