Bugfix for snow grain aging, snow tracer updates and snow surface layer #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. corrections to snow grain wet matamorphism (set bound on liquid fraction and unit conversion error), snow grain radius initialization, and removes incorrect calls to cice tracer arrays (nonBFB in regression test for snow_tracer_physics. BFB in all other regression tests). 2. corrects snow surface layer contribution to accumulated bgc snow tracer diagnostic. Except for snow_tracer_physics regression test, all others pass.
eclare108213
added a commit
to Arctic-InteRFACE/Icepack
that referenced
this pull request
Mar 15, 2021
eclare108213
added a commit
to CICE-Consortium/Icepack
that referenced
this pull request
Aug 11, 2021
* new snow tracer implementation (no physics) * snow redistribution testing options * settings for 3 snow layers, the way Icepack wants them * setenv correction * add rhosmin, snwlvlfac to namelist, change snwredist opetion from 30percent to bulk, fix domain size * add ice_snow module; compiles, no hooks from main code, module conversion for Icepack incomplete * rename ice_snow.F90, add icepack_step_snow, call drain_snow, move adjust_enthalpy, add snowage parameters * bug fix: dsnow was not being aggregated from category values * add calls to new snow physics routines * call update_state, make optional arguments * snow interactions with thermo (except dEdd) * snow interactions in dEdd * add meltsliq to ponds, clean up * adding snwgrain namelist flag * Bug fixes from MPAS-Dev/MPAS-Model#314 * constrain calculations based on configuration options, add diagnostics, initialize, debug, clean up * make dsnow optional * snow aging table for dry metamorphism * env for snwgrain test * snow documentation, first draft * snow case settings * fix step_therm1 interface and some documentation errors * documentation corrections * complete step_therm1 interface fix; bug fix in bgc diagnostics * metamorphism updates to doc with notes for things needing to be checked against the code * remove unused variable * add snow tests to base_suite * initialize snow tracer indices when unused; update documentation * TRSNOW 0 when not using advanced snow physics * fix snow restarts, clean up unused flags * updating snow documentation * adding snow namelist info to science guide * update icepack to support snowtable better * adjust parameter values, test options * send rsnw to dEdd; limit rsnw below; fix snow SSL for z tracers * updating snow options in icepack for consistency with cice * reformulate ice-liquid tracer conversions in snow; limit use of rsnow in dEdd with snwgrain; correct rhos_effn; clean up * another approach for ice/liquid tracer conversions in snow * enforce mass conservation of snow ice and liquid tracers, to maintain consistency with rhos based snow volume transport * create temporary array for rsnow in shortwave calls to avoid array-out-of-bounds error when snwgrain=F * reset default/initial tracer values when snow disappears; some cleanup * Bug fix for bulk redistribution precipitation factor. Commented out shortwave modification for bulk redistribution - it should not be used for production runs without more careful analysis of the energy balance between level and ridged ice. * Another bug fix for bulk redistribution precipitation factor - average alvl weighted by aice. Reinstated shortwave modification for bulk redistribution - it works the same as for ITDrdg. Updated documentation. * cleanup * remove rnsw_dEdd array, load tracer instead; use rsnw_fall instead of rsnw_fresh in dEdd, set dEdd default value in namelist and tr_snow value in options * Removed variables that were only for history output, instead using the tracer array directly; the snow_effective_density subroutine was then also unnecessary. * initialize density tracer; fix history output for CICE Co-authored-by: apcraig <anthony.p.craig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corrections to snow grain wet matamorphism
(set bound on liquid fraction and unit conversion error),
corrects snow grain radius initialization, and removes incorrect calls to
cice tracer arrays (nonBFB in regression test for snow_tracer_physics.
BFB in all other regression tests).
corrects snow surface layer contribution to accumulated bgc snow tracer diagnostic.
Except for snow_tracer_physics regression test, all other tests and testsuites pass.