Skip to content

Conversation

@jihyeonjang
Copy link
Collaborator

This PR enables the "temperature" variable in the "history" output.

By adding "temperature" to stream_list.atmosphere.output, the history files will include temperature(Time, nCells, nVertLevels).

@jihyeonjang jihyeonjang requested a review from mgduda January 29, 2026 22:39
@byoung-joo
Copy link
Contributor

This should be very useful, which can provide a direct access to the "temperature" variable.
I wonder if we can add the same thing to subroutine atm_compute_output_diagnostics for spechum, but with a jedi_da package maybe.

@jihyeonjang
Copy link
Collaborator Author

@mgduda -- what do you think? I think this is doable, but we should confirm the variables are updated each time step so the output reflects the correct values.

@byoung-joo -- for DA runs, is it OK to remove "packages="jedi_da"" from the "temperature" variable definition in Registry.xml?

@byoung-joo
Copy link
Contributor

I think this is doable, but we should confirm the variables are updated each time step so the output reflects the correct values.

Yes, the added computation at each time step is a side effect. I wonder if we can add spechum diagnostic in other place... perhaps somewhere from the diagnostic directory (again with jedi_da package)?

for DA runs, is it OK to remove "packages="jedi_da"" from the "temperature" variable definition in Registry.xml?

Then, the variable temperature would be always available, so it should not affect the DA application (I think). Let me know if I misunderstand about this.

@jihyeonjang jihyeonjang force-pushed the add_output_temperature branch from 1a4c4d5 to cfb8098 Compare January 30, 2026 22:31
@jihyeonjang
Copy link
Collaborator Author

jihyeonjang commented Jan 30, 2026

Yes, the added computation at each time step is a side effect. I wonder if we can add spechum diagnostic in other place... perhaps somewhere from the diagnostic directory (again with jedi_da package)?

I agree that computing these every time step is unnecessary for output-only variables. I removed the changes from subroutine atm_compute_output_diagnostics and instead compute temperature and spechum in the diagnostics module. So they are only computed when written to output (no timestep overhead).

Also, temperature and spechum are no longer with packages="jedi_da", so they are available for diagnostics output.

Thus, with this PR, temperature and spechum will be written to output when added to the stream_list file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants