Skip to content

fixed errors when compile MPAS with gfortran with -fimplicit-none #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fixed errors when compile MPAS with gfortran with -fimplicit-none #1271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/core_atmosphere/diagnostics/mpas_cloud_diagnostics.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ module mpas_cloud_diagnostics

type (MPAS_clock_type), pointer :: clock

public :: cloud_diagnostics_setup, &
cloud_diagnostics_compute, &

private

public :: cloud_diagnostics_setup, &
cloud_diagnostics_compute


contains

Expand Down
2 changes: 1 addition & 1 deletion src/core_atmosphere/physics/mpas_atmphys_lsm_noahmpinit.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ subroutine noahmp_init(configs,mesh,diag_physics,diag_physics_noahmp,output_noah
!local variables and pointers:
logical,pointer:: do_restart
logical,parameter:: fndsnowh = .true.
integer:: i,its,ite,ns,nsoil,nsnow,nzsnow
integer:: i,its,ite,n,ns,nsoil,nsnow,nzsnow

!-----------------------------------------------------------------------------------------------------------------
!call mpas_log_write(' ')
Expand Down
1 change: 1 addition & 0 deletions src/core_atmosphere/physics/physics_wrf/module_cu_gf.mpas.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3489,6 +3489,7 @@ SUBROUTINE neg_check(j,subt,subq,dt,q,outq,outt,outqc,pret,its,ite,kts,kte,itf,k
,intent (in ) :: &
dt
real :: thresh,qmem,qmemf,qmem2,qtest,qmem1
integer :: i,k
!
! first do check on vertical heating rate
!
Expand Down
3 changes: 3 additions & 0 deletions src/core_atmosphere/physics/physics_wrf/module_sf_urban.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2974,6 +2974,8 @@ SUBROUTINE bisection(TSP,PS,S,EPS,RX,SIG,RHO,CP,CH,UA,QA,TA,EL,BET,AKS,TSL,DZ,TS
REAL, INTENT(IN) :: TSP,PS,S,EPS,RX,SIG,RHO,CP,CH,UA,QA,TA,EL,BET,AKS,TSL,DZ
REAL, INTENT(OUT) :: TS
REAL :: ES,QS0,R,H,ELE,G0,F1,F
REAL :: TS1, TS2
INTEGER :: ITERATION

TS1 = TSP - 5.
TS2 = TSP + 5.
Expand Down Expand Up @@ -3246,6 +3248,7 @@ SUBROUTINE TRANSP (ETT,ET,EC,SHDFAC,ETP1,CMC,CFACTR,CMCMAX,LAI,RSMIN,RSMAX,RGL,S
REAL, INTENT(OUT) :: EC, ETT
REAL :: RC, RCS, RCT, RCQ, RCSOIL, FF, WS, SLV, DESDT
REAL :: SIGMA, PC, CMC2MS, SGX, DENOM, RTX, ETT1
REAL :: EA, DELTA, RR
INTEGER :: K
REAL, DIMENSION(1:NROOT) :: PART, GX

Expand Down
1 change: 1 addition & 0 deletions src/framework/mpas_block_creator.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -984,6 +984,7 @@ subroutine mpas_block_creator_finalize_block_phase1(nHalos, blocklist, nCellsSol
type (field1dInteger), pointer :: nCellsCursor, nEdgesCursor, nVerticesCursor
type (field1dInteger), pointer :: indexToCellCursor, indexToEdgeCursor, indexToVertexCursor

integer :: nCells, nEdges, nVertices
integer :: nCellsSolve_0Halo, nVerticesSolve_0Halo, nEdgesSolve_0Halo
integer :: blockID, localBlockID, err_level, iErr

Expand Down
9 changes: 9 additions & 0 deletions src/framework/mpas_field_routines.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ subroutine mpas_allocate_scratch_field1d_integer(f, single_block_in, init_array_
logical :: single_block, init_array
type (field1dInteger), pointer :: f_cursor
integer :: threadNum
integer :: i

if(f % isPersistent) then
return
Expand Down Expand Up @@ -232,6 +233,7 @@ subroutine mpas_allocate_scratch_field2d_integer(f, single_block_in, init_array_
logical :: single_block, init_array
type (field2dInteger), pointer :: f_cursor
integer :: threadNum
integer :: i,j

if(f % isPersistent) then
return
Expand Down Expand Up @@ -324,6 +326,7 @@ subroutine mpas_allocate_scratch_field3d_integer(f, single_block_in, init_array_
logical :: single_block, init_array
type (field3dInteger), pointer :: f_cursor
integer :: threadNum
integer :: i,j,k

if(f % isPersistent) then
return
Expand Down Expand Up @@ -416,6 +419,7 @@ subroutine mpas_allocate_scratch_field1d_real(f, single_block_in, init_array_in)
logical :: single_block, init_array
type (field1dReal), pointer :: f_cursor
integer :: threadNum
integer :: i

if(f % isPersistent) then
return
Expand Down Expand Up @@ -504,6 +508,7 @@ subroutine mpas_allocate_scratch_field2d_real(f, single_block_in, init_array_in)
logical :: single_block, init_array
type (field2dReal), pointer :: f_cursor
integer :: threadNum
integer :: i,j

if(f % isPersistent) then
return
Expand Down Expand Up @@ -594,6 +599,7 @@ subroutine mpas_allocate_scratch_field3d_real(f, single_block_in, init_array_in)
logical :: single_block, init_array
type (field3dReal), pointer :: f_cursor
integer :: threadNum
integer :: i,j,k

if(f % isPersistent) then
return
Expand Down Expand Up @@ -686,6 +692,7 @@ subroutine mpas_allocate_scratch_field4d_real(f, single_block_in, init_array_in)
logical :: single_block, init_array
type (field4dReal), pointer :: f_cursor
integer :: threadNum
integer :: i,j,k,l

if(f % isPersistent) then
return
Expand Down Expand Up @@ -782,6 +789,7 @@ subroutine mpas_allocate_scratch_field5d_real(f, single_block_in, init_array_in)
logical :: single_block, init_array
type (field5dReal), pointer :: f_cursor
integer :: threadNum
integer :: i,j,k,l,m

if(f % isPersistent) then
return
Expand Down Expand Up @@ -882,6 +890,7 @@ subroutine mpas_allocate_scratch_field1d_char(f, single_block_in, init_array_in)
logical :: single_block, init_array
type (field1dChar), pointer :: f_cursor
integer :: threadNum
integer :: i

if(f % isPersistent) then
return
Expand Down
2 changes: 2 additions & 0 deletions src/framework/mpas_framework.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ module mpas_framework
use mpas_io_units
use mpas_block_decomp

#ifdef MPAS_OPENACC
private :: report_acc_devices
#endif


contains
Expand Down
1 change: 1 addition & 0 deletions src/framework/mpas_timekeeping.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ end subroutine mpas_timekeeping_finalize
!-----------------------------------------------------------------------
subroutine mpas_timekeeping_set_year_width(yearWidthIn)!{{{
integer, intent(in) :: yearWidthIn
integer :: ierr

yearWidth = yearWidthIn

Expand Down