Skip to content

Added separate driver to call the parameterization of seaice #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

ldfowler58
Copy link
Contributor

In preparation to adding the Noah-MP land surface scheme (LSM), and because the Noah and Noah-MP LSMs share the same parameterization of sea-ice, I moved all the sourcecode related to sea-ice that currently sits in the Noah LSM driver to its own driver (mpas_atmphys_driver_seaice.F). The call to the sea-ice driver is located in the main driver after the call to the Noah LSM. All outputs are bit for bit the same relative to the original parameterization.

…r_seaice.F:

  -> mpas_atmphys_driver_seaice.F contains all the sourcecode related to surface
     processes over seaice points.

  -> in mpas_atmphys_driver_lsm.F, removed all the sourcecode related to surface
     processes over seaice points and moved the sourcecode to the seaice driver.

  -> changed Makefile accordingly.
@mgduda mgduda self-requested a review March 26, 2024 03:14
Copy link
Contributor

@mgduda mgduda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted, I think it would be good to add OpenMP directives for loop around the driver_seaice call.

…P directives around

  the loop that calls the seaice driver.
@mgduda mgduda self-requested a review March 27, 2024 20:22
Copy link
Contributor

@mgduda mgduda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more small change regarding a copyright statement.

@mgduda mgduda self-requested a review March 27, 2024 21:51
@mgduda mgduda merged commit c057136 into MPAS-Dev:develop Mar 27, 2024
@ldfowler58 ldfowler58 deleted the NSF-MPAS/lsm_seaice branch June 16, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants