Skip to content

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Mar 26, 2025

If not, delete climatology and start fresh

Checklist

  • Testing comment in the PR documents testing used to verify the changes

fixes #1078

@xylar xylar requested a review from irenavankova March 26, 2025 03:38
@xylar xylar added the bug label Mar 26, 2025
@xylar xylar self-assigned this Mar 26, 2025
Copy link
Collaborator

@irenavankova irenavankova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me, thanks for the quick fix

@xylar
Copy link
Collaborator Author

xylar commented Mar 27, 2025

I still need to test this to make sure it actually works...

If not, delete climatology and start fresh
@xylar xylar force-pushed the check-bsf-region-list branch from df40dc8 to a5c9994 Compare April 7, 2025 18:10
@xylar
Copy link
Collaborator Author

xylar commented Apr 7, 2025

Finally getting around to testing this now.

@xylar
Copy link
Collaborator Author

xylar commented Apr 7, 2025

Testing

I ran this PR though the test suite:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xasay-davis/analysis_testing/chrysalis/check-bsf-region-list/

I then reran the main_py3.11 test after adding another region for the North Pacific. The test ran successfully and produced the desired additional plot:
image

@xylar xylar marked this pull request as ready for review April 7, 2025 20:47
@xylar xylar merged commit 54ca87e into MPAS-Dev:develop Apr 7, 2025
5 checks passed
@xylar xylar deleted the check-bsf-region-list branch April 7, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

descriptive BSF error message

2 participants