Fix importlib.resources calls for colormap data
#1075
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least for python 3.10, we cannot supplly a path as part of the filename. In general, we do not want to do this anyway, and instead want to use the full package path.
Collaborator
Author
TestingI ran the test suite with this (using python 3.10) and it seems to work, whereas it didn't before this fix. See: |
xylar
added a commit
to xylar/MPAS-Analysis
that referenced
this pull request
Mar 12, 2025
Fix `importlib.resources` calls for colormap data
Collaborator
Author
|
This got merged but GitHub doesn't seem to have noticed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least for python 3.10, we cannot supply a path as part of the filename. In general, we do not want to do this anyway, and instead want to use the full package path.
Checklist
Testingcomment in the PR documents testing used to verify the changes