Skip to content

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Feb 18, 2025

The task ClimatologyMapCustom can be used to make climatology maps of 2D and 3D fields on cells, the latter with vertical dimension nVertLevels or nVertLevelsP1.

To support this, RemapDepthSlicesSubtask has been updated to support nVertLevelsP1 and a new utility function has been added to compute the z coordinate at layer interfaces.

Checklist

  • User's Guide has been updated
  • If this PR adds a new analysis task, it has also been added to the user's guide
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes

@xylar
Copy link
Collaborator Author

xylar commented Feb 18, 2025

@irenavankova, this is the first of 2 features you requested. It seems to work, see:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis/v3.LR.piControl/clim_custom/ocean/index.html
(config options here https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis/v3.LR.piControl/clim_custom/v3.LR.piControl.cfg)

(Note: the web server has cached old versions of some plots. Hopefully, these will update again in a few hours.)

I need to:

  • add documentation
  • test on 2D fields
  • run the test suite (in progress)

In the meantime, give it a shot and let me know what you think. Happy to add more variables to defaults.cfg that you think might be useful.

@xylar xylar force-pushed the add-climatology-map-at-depths branch 2 times, most recently from 297b92d to 1dc9c35 Compare February 19, 2025 14:32
@xylar
Copy link
Collaborator Author

xylar commented Feb 19, 2025

Testing

Here are some update results showing both 2D and 3D fields, the latter with both nVertLevels and nVertLevelsP1 as the vertical dimension:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis/v3.LR.piControl/clim_custom/ocean/index.html

I have also successfully run the developer suite:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xasay-davis/analysis_testing/chrysalis/add-climatology-map-at-depths/

@xylar xylar force-pushed the add-climatology-map-at-depths branch from 1dc9c35 to 53b43b8 Compare February 19, 2025 14:37
@xylar
Copy link
Collaborator Author

xylar commented Feb 19, 2025

I think this will be ready for review as soon as v1.13.0 get released.

@xylar xylar marked this pull request as ready for review April 7, 2025 00:31
xylar added 4 commits April 6, 2025 19:32
This analysis task supports a custom list of variables on cells
to be plotted at selected depths and on specified maps and over
the desired seasons.
@xylar xylar force-pushed the add-climatology-map-at-depths branch from 53b43b8 to c03c986 Compare April 7, 2025 00:32
@xylar xylar requested a review from irenavankova April 7, 2025 00:33
@xylar xylar self-assigned this Apr 7, 2025
@xylar
Copy link
Collaborator Author

xylar commented Apr 7, 2025

@irenavankova, I know you have used this already. I would like to get it merge into MPAS-Analysis soon. Could you give it a review based on your testing?

Copy link
Collaborator

@irenavankova irenavankova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have used this and it works great. I added extra fields and it was very easy to do.

This is a really useful feature for more personalized analysis and paper writing as it does not rely on availability of observations. It would be great to have for sea ice also, where come fields (e.g. Ice thickness) can only by plotted over seasons when obs are available.

@xylar
Copy link
Collaborator Author

xylar commented Apr 7, 2025

Thanks @irenavankova!

@xylar xylar merged commit 9741b1d into MPAS-Dev:develop Apr 7, 2025
5 checks passed
@xylar xylar deleted the add-climatology-map-at-depths branch April 7, 2025 18:01
'has_depth': False},
}

# a list of fields top plot for each transect. All supported fields are listed
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, transect should have been climatology...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok, just a comment - I was scared for a second it is picking up something else then I thought and that my analysis is wrong :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants