-
Notifications
You must be signed in to change notification settings - Fork 53
Add support for custom climatology maps #1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@irenavankova, this is the first of 2 features you requested. It seems to work, see: (Note: the web server has cached old versions of some plots. Hopefully, these will update again in a few hours.) I need to:
In the meantime, give it a shot and let me know what you think. Happy to add more variables to |
297b92d to
1dc9c35
Compare
TestingHere are some update results showing both 2D and 3D fields, the latter with both I have also successfully run the developer suite: |
1dc9c35 to
53b43b8
Compare
|
I think this will be ready for review as soon as v1.13.0 get released. |
This analysis task supports a custom list of variables on cells to be plotted at selected depths and on specified maps and over the desired seasons.
53b43b8 to
c03c986
Compare
|
@irenavankova, I know you have used this already. I would like to get it merge into MPAS-Analysis soon. Could you give it a review based on your testing? |
irenavankova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have used this and it works great. I added extra fields and it was very easy to do.
This is a really useful feature for more personalized analysis and paper writing as it does not rely on availability of observations. It would be great to have for sea ice also, where come fields (e.g. Ice thickness) can only by plotted over seasons when obs are available.
|
Thanks @irenavankova! |
| 'has_depth': False}, | ||
| } | ||
|
|
||
| # a list of fields top plot for each transect. All supported fields are listed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, transect should have been climatology...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok, just a comment - I was scared for a second it is picking up something else then I thought and that my analysis is wrong :)
The task
ClimatologyMapCustomcan be used to make climatology maps of 2D and 3D fields on cells, the latter with vertical dimensionnVertLevelsornVertLevelsP1.To support this,
RemapDepthSlicesSubtaskhas been updated to supportnVertLevelsP1and a new utility function has been added to compute the z coordinate at layer interfaces.Checklist
api.rst) has any new or modified class, method and/or functions listedTestingcomment in the PR documents testing used to verify the changes