Feat/humble: add support for ROS2 humble (LTS until May 2027) #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced new Dockerfile for Humble version and updated CI workflow to include Humble builds. - Updated pre-commit configuration to lint both Noetic and Humble Dockerfiles. - Enhanced README with build instructions for Humble version. - Added necessary package definitions and requirements for Humble. - Updated Noetic Dockerfile to remove hardcoded manager URI and bump mobros version.
…or Dockerfiles and tests
…stall python3-pip and adjust requirements
AlexFernandes-MOVAI
requested review from
duartecoelhomovai and
mariana-dias-alves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for building and testing new ROS2 Humble-based Docker images for the MOV.AI Spawner, alongside improvements to build automation, package management, and CI workflows. The changes add new Dockerfiles, update build instructions and scripts, extend pre-commit checks, and enhance the Makefile to support multiple flavors and architectures.
Docker image and build system enhancements:
docker/humble/Dockerfileto support ROS2 Humble and Humble Ignition spawner base images, including all provisioning, environment, and dependency setup for these flavors. [1] [2] [3]Makefileto support building, running, testing, and pushing all active image flavors (Noetic, Ign-Noetic, Humble, Humble-Python38), with multi-architecture build and size check support.CI and automation improvements:
.github/workflows/docker-ci.ymlto build and deploy Humble spawner images on tag pushes, with proper secrets and public/private registry handling. [1] [2].pre-commit-config.yamlto run hadolint checks on both Noetic and Humble Dockerfiles for linting.Package management and cleanup:
docker/humble/packages/packages.apt,requirements.txt, andmovai.rosinstallfor apt and pip dependencies. [1] [2] [3]scripts/base/install-packages.shfor more robust and thorough removal of temporary files and apt cache. [1] [2]Documentation:
README.mdto include build instructions for Humble and Humble IGN spawner images.References:
[1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]