#287 fix wrong labels #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
benitsch
commented
Aug 5, 2024
•
benitsch
commented
- If a second questionnaire is available, it will merge other possible answer options into the chart labels. Now this is not the case anymore (fixed)
- Now all other possible answer option for a specific questionnaire is added to the data view data later on.
- Fix invalid date format for build info
Test Results94 tests 93 ✅ 1m 18s ⏱️ Results for commit 9fa4f0d. ♻️ This comment has been updated with latest results. |
benitsch
force-pushed
the
MORE-287_fix_wrong_labels
branch
2 times, most recently
from
b227bd3
to
ee4284f
Compare
benitsch
force-pushed
the
MORE-287_fix_wrong_labels
branch
from
ee4284f
to
4fde0dd
Compare
ja-fra
approved these changes
Aug 8, 2024
* To add all other possible answer option for a specific questionnaire the function addMissingAnswerOptions is introduced. * If a second questionnaire is available, it will merge other possible answer options into the chart labels. Now this is not the case anymore (fixed).
* Avoid js exception for new Date() with invalid date format as argument.
benitsch
force-pushed
the
MORE-287_fix_wrong_labels
branch
from
4fde0dd
to
9fa4f0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.