[Feat] Comment reply notifications and chat page & sharing improvements#782
[Feat] Comment reply notifications and chat page & sharing improvements#782CREDO23 wants to merge 13 commits intoMODSetter:devfrom
Conversation
|
@CREDO23 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on 8c60910..1cf7205
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (16)
• surfsense_backend/app/services/chat_comments_service.py
• surfsense_backend/app/services/notification_service.py
• surfsense_backend/app/services/public_chat_service.py
• surfsense_web/components/assistant-ui/assistant-message.tsx
• surfsense_web/components/assistant-ui/branch-picker.tsx
• surfsense_web/components/assistant-ui/user-message.tsx
• surfsense_web/components/layout/providers/LayoutDataProvider.tsx
• surfsense_web/components/layout/ui/sidebar/InboxSidebar.tsx
• surfsense_web/components/new-chat/chat-share-button.tsx
• surfsense_web/components/public-chat-snapshots/public-chat-snapshot-row.tsx
• surfsense_web/components/theme/theme-toggle.tsx
• surfsense_web/contracts/types/inbox.types.ts
• surfsense_web/hooks/use-api-key.ts
• surfsense_web/lib/utils.ts
• surfsense_web/messages/en.json
• surfsense_web/messages/zh.json
Description
Change Type
Testing Performed
Checklist
High-level PR Summary
This PR enhances the chat commenting and notification system by introducing comment reply notifications that notify thread participants when someone replies. The Mentions tab has been renamed to Comments with a speech bubble icon to better reflect its expanded purpose. The notification system was refactored to fix duplicate notifications and correct inbox count calculations. Chat UI improvements include removing the branch picker component, restricting the edit button to only the last user message, and restricting the regenerate button to only the last assistant message. Public sharing functionality was improved by adding a globe indicator when public snapshots exist, showing selectable URLs in public link rows, relaxing permissions to view (not just create) public share links, and extracting a reusable clipboard utility with fallback support for non-secure contexts. Additional UI polish includes formatting improvements to the theme toggle component.
⏱️ Estimated Review Time: 30-90 minutes
💡 Review Order Suggestion
surfsense_web/contracts/types/inbox.types.tssurfsense_backend/app/services/notification_service.pysurfsense_backend/app/services/chat_comments_service.pysurfsense_web/hooks/use-api-key.tssurfsense_web/lib/utils.tssurfsense_web/components/layout/providers/LayoutDataProvider.tsxsurfsense_web/components/layout/ui/sidebar/InboxSidebar.tsxsurfsense_web/messages/en.jsonsurfsense_web/messages/zh.jsonsurfsense_web/components/assistant-ui/branch-picker.tsxsurfsense_web/components/assistant-ui/assistant-message.tsxsurfsense_web/components/assistant-ui/user-message.tsxsurfsense_backend/app/services/public_chat_service.pysurfsense_web/components/new-chat/chat-share-button.tsxsurfsense_web/components/public-chat-snapshots/public-chat-snapshot-row.tsxsurfsense_web/components/theme/theme-toggle.tsxsurfsense_web/components/theme/theme-toggle.tsx