[Feat] Migrate GitHub connector to use httpsgithubcomcoderamp #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CREDO23 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on 70890bd..17c7a19
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (8)
• surfsense_backend/app/connectors/github/__init__.py
• surfsense_backend/app/connectors/github/client.py
• surfsense_backend/app/connectors/github/constants.py
• surfsense_backend/app/connectors/github/service.py
• surfsense_backend/app/connectors/github_connector.py
• surfsense_backend/app/routes/search_source_connectors_routes.py
• surfsense_backend/app/tasks/connector_indexers/github_indexer.py
• surfsense_backend/pyproject.toml
- Convert GitIngestService.process_repository() to async using ingest_async() - Convert GitHubConnector.process_repository() to async - Update github_indexer to await async process_repository() call - Prevents blocking event loop in Celery tasks - Improves performance and concurrency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
API Changes
Change Type
Testing Performed
Checklist
High-level PR Summary
This PR represents an architectural migration of the GitHub connector from a file-by-file indexing approach to a bulk repository processing approach using the
gitingestlibrary. The originalgithub_connector.pymodule (296 lines) that recursively traversed repository files and processed them individually has been replaced with a new modular structure underapp/connectors/github/that leveragesgitingestto convert entire repositories into text format optimized for LLM processing. The new implementation processes repositories as single documents rather than individual files, significantly changing the indexing strategy and document structure. The migration also updates the indexer task to work with the new bulk processing model, removing date filtering logic and reducing the granularity from per-file to per-repository documents.⏱️ Estimated Review Time: 30-90 minutes
💡 Review Order Suggestion
surfsense_backend/pyproject.tomlsurfsense_backend/app/connectors/github/constants.pysurfsense_backend/app/connectors/github/__init__.pysurfsense_backend/app/connectors/github/service.pysurfsense_backend/app/connectors/github/client.pysurfsense_backend/app/routes/search_source_connectors_routes.pysurfsense_backend/app/tasks/connector_indexers/github_indexer.pysurfsense_backend/app/connectors/github_connector.py