Skip to content

Dependency issue#360

Closed
iamsyg wants to merge 2 commits intoMODSetter:mainfrom
iamsyg:dependency-issue
Closed

Dependency issue#360
iamsyg wants to merge 2 commits intoMODSetter:mainfrom
iamsyg:dependency-issue

Conversation

@iamsyg
Copy link
Contributor

@iamsyg iamsyg commented Oct 3, 2025

Description

Motivation and Context

FIX #

Changes Overview

Screenshots

API Changes

  • This PR includes API changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance improvement (non-breaking change which enhances performance)
  • Documentation update
  • Breaking change (fix or feature that would cause existing functionality to change)

Testing

  • I have tested these changes locally
  • I have added/updated unit tests
  • I have added/updated integration tests

Checklist:

  • My code follows the code style of this project
  • My change requires documentation updates
  • I have updated the documentation accordingly
  • My change requires dependency updates
  • I have updated the dependencies accordingly
  • My code builds clean without any errors or warnings
  • All new and existing tests passed

High-level PR Summary

This Pull Request addresses a dependency issue by replacing the motion package with framer-motion. The changes include updating import statements across multiple files from motion/react to framer-motion, updating package dependencies in package.json, and making minor adjustments to accommodate the new package. Additionally, the PR updates the Sonner toast component to a newer version (2.0.7) and modifies its implementation. The primary focus of this PR is to fix dependency issues rather than introducing new features or functionality.

⏱️ Estimated Review Time: 5-15 minutes

💡 Review Order Suggestion
Order File Path
1 surfsense_web/package.json
2 surfsense_web/package-lock.json
3 surfsense_web/pnpm-lock.yaml
4 surfsense_web/app/dashboard/[search_space_id]/chats/chats-client.tsx
5 surfsense_web/components/ui/sonner.tsx
6 surfsense_web/app/dashboard/[search_space_id]/connectors/(manage)/page.tsx
7 surfsense_web/components/Navbar.tsx
8 surfsense_web/components/ModernHeroWithGradients.tsx

Need help? Join our Discord

Analyze latest changes

@vercel
Copy link

vercel bot commented Oct 3, 2025

@iamsyg is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link

coderabbitai bot commented Oct 3, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Project-wide animation library migration from motion/react to framer-motion across app pages and components. Minor typing tweak in Navbar. Toaster (Sonner) component simplified to rely on style props instead of per-toast classNames. package.json switches dev script and swaps dependencies (add framer-motion, remove motion, bump sonner). A couple of newline-only formatting changes.

Changes

Cohort / File(s) Summary
Animation import migration — App pages
surfsense_web/app/dashboard/page.tsx, .../dashboard/searchspaces/page.tsx, .../dashboard/api-key/api-key-client.tsx, .../dashboard/[search_space_id]/chats/chats-client.tsx, .../dashboard/[search_space_id]/connectors/(manage)/page.tsx, .../dashboard/[search_space_id]/connectors/[connector_id]/edit/page.tsx, .../dashboard/[search_space_id]/connectors/[connector_id]/page.tsx, .../dashboard/[search_space_id]/connectors/add/page.tsx, .../dashboard/[search_space_id]/connectors/add/*-connector/page.tsx, .../dashboard/[search_space_id]/connectors/add/*-api/page.tsx, .../dashboard/[search_space_id]/documents/(manage)/page.tsx, .../dashboard/[search_space_id]/documents/(manage)/components/*, .../dashboard/[search_space_id]/documents/upload/page.tsx, .../dashboard/[search_space_id]/documents/youtube/page.tsx, .../dashboard/[search_space_id]/logs/(manage)/page.tsx, surfsense_web/app/login/*, surfsense_web/app/onboard/page.tsx, surfsense_web/app/register/page.tsx
Replace imports from "motion/react" to "framer-motion" (AnimatePresence, motion, Variants, hooks) with no logic changes.
Animation import migration — Components
surfsense_web/components/ModernHeroWithGradients.tsx, .../components/Navbar.tsx, .../components/chat/AnimatedEmptyState.tsx, .../components/contact/contact-form.tsx, .../components/onboard/*-step.tsx, .../components/pricing.tsx, .../components/search-space-form.tsx, .../components/settings/*, .../components/theme/theme-toggle.tsx, .../components/ui/spotlight.tsx, .../components/ui/tilt.tsx
Swap to framer-motion; same identifiers and usage. Navbar adds explicit type for latest in useMotionValueEvent.
Toaster rendering simplification
surfsense_web/components/ui/sonner.tsx
Simplifies Toaster: removes granular toastOptions/classNames; uses with style (CSS variables). Adjusts imports and formatting; export unchanged.
Dependency and script updates
surfsense_web/package.json
Dev script: "next dev --turbopack" → "next dev". Add framer-motion, remove motion, bump sonner ^2.0.6 → ^2.0.7.
Formatting-only changes
surfsense_web/app/contact/page.tsx, surfsense_web/app/pricing/page.tsx
Newline/trailing newline adjustments; no functional changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • MODSetter

Poem

I hopped through files, line by line,
Swapped motion for framer—looking fine.
The Toaster now is crisp and neat,
With styled vibes and subtle heat.
Scripts updated, deps aligned—
A bunny’s merge, precisely timed. 🐇✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd41038 and 38b2570.

⛔ Files ignored due to path filters (2)
  • surfsense_web/package-lock.json is excluded by !**/package-lock.json
  • surfsense_web/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (52)
  • surfsense_web/app/contact/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/chats/chats-client.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/connectors/(manage)/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/connectors/[connector_id]/edit/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/connectors/[connector_id]/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/connectors/add/airtable-connector/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/connectors/add/confluence-connector/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/connectors/add/discord-connector/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/connectors/add/github-connector/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/connectors/add/google-calendar-connector/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/connectors/add/google-gmail-connector/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/connectors/add/jira-connector/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/connectors/add/linear-connector/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/connectors/add/linkup-api/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/connectors/add/luma-connector/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/connectors/add/notion-connector/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/connectors/add/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/connectors/add/serper-api/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/connectors/add/slack-connector/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/connectors/add/tavily-api/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/DocumentsFilters.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/DocumentsTableShell.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/PaginationControls.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/documents/upload/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/documents/youtube/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/[search_space_id]/logs/(manage)/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/api-key/api-key-client.tsx (1 hunks)
  • surfsense_web/app/dashboard/page.tsx (1 hunks)
  • surfsense_web/app/dashboard/searchspaces/page.tsx (1 hunks)
  • surfsense_web/app/login/GoogleLoginButton.tsx (1 hunks)
  • surfsense_web/app/login/LocalLoginForm.tsx (1 hunks)
  • surfsense_web/app/login/page.tsx (1 hunks)
  • surfsense_web/app/onboard/page.tsx (1 hunks)
  • surfsense_web/app/pricing/page.tsx (1 hunks)
  • surfsense_web/app/register/page.tsx (1 hunks)
  • surfsense_web/components/ModernHeroWithGradients.tsx (1 hunks)
  • surfsense_web/components/Navbar.tsx (2 hunks)
  • surfsense_web/components/chat/AnimatedEmptyState.tsx (1 hunks)
  • surfsense_web/components/contact/contact-form.tsx (1 hunks)
  • surfsense_web/components/onboard/add-provider-step.tsx (1 hunks)
  • surfsense_web/components/onboard/assign-roles-step.tsx (1 hunks)
  • surfsense_web/components/onboard/completion-step.tsx (1 hunks)
  • surfsense_web/components/pricing.tsx (1 hunks)
  • surfsense_web/components/search-space-form.tsx (1 hunks)
  • surfsense_web/components/settings/llm-role-manager.tsx (1 hunks)
  • surfsense_web/components/settings/model-config-manager.tsx (1 hunks)
  • surfsense_web/components/theme/theme-toggle.tsx (1 hunks)
  • surfsense_web/components/ui/sonner.tsx (1 hunks)
  • surfsense_web/components/ui/spotlight.tsx (1 hunks)
  • surfsense_web/components/ui/tilt.tsx (1 hunks)
  • surfsense_web/package.json (3 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@iamsyg iamsyg closed this Oct 3, 2025
Copy link

@recurseml recurseml bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by RecurseML

🔍 Review performed on cd41038..38b2570

✨ No bugs found, your code is sparkling clean

✅ Files analyzed, no issues (5)

surfsense_web/components/ui/sonner.tsx
surfsense_web/components/Navbar.tsx
surfsense_web/app/contact/page.tsx
surfsense_web/app/dashboard/[search_space_id]/chats/chats-client.tsx
surfsense_web/app/dashboard/[search_space_id]/connectors/(manage)/page.tsx

⏭️ Files skipped (49)
  Locations  
surfsense_web/app/dashboard/[search_space_id]/connectors/[connector_id]/edit/page.tsx
surfsense_web/app/dashboard/[search_space_id]/connectors/[connector_id]/page.tsx
surfsense_web/app/dashboard/[search_space_id]/connectors/add/airtable-connector/page.tsx
surfsense_web/app/dashboard/[search_space_id]/connectors/add/confluence-connector/page.tsx
surfsense_web/app/dashboard/[search_space_id]/connectors/add/discord-connector/page.tsx
surfsense_web/app/dashboard/[search_space_id]/connectors/add/github-connector/page.tsx
surfsense_web/app/dashboard/[search_space_id]/connectors/add/google-calendar-connector/page.tsx
surfsense_web/app/dashboard/[search_space_id]/connectors/add/google-gmail-connector/page.tsx
surfsense_web/app/dashboard/[search_space_id]/connectors/add/jira-connector/page.tsx
surfsense_web/app/dashboard/[search_space_id]/connectors/add/linear-connector/page.tsx
surfsense_web/app/dashboard/[search_space_id]/connectors/add/linkup-api/page.tsx
surfsense_web/app/dashboard/[search_space_id]/connectors/add/luma-connector/page.tsx
surfsense_web/app/dashboard/[search_space_id]/connectors/add/notion-connector/page.tsx
surfsense_web/app/dashboard/[search_space_id]/connectors/add/page.tsx
surfsense_web/app/dashboard/[search_space_id]/connectors/add/serper-api/page.tsx
surfsense_web/app/dashboard/[search_space_id]/connectors/add/slack-connector/page.tsx
surfsense_web/app/dashboard/[search_space_id]/connectors/add/tavily-api/page.tsx
surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/DocumentsFilters.tsx
surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/DocumentsTableShell.tsx
surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/PaginationControls.tsx
surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/page.tsx
surfsense_web/app/dashboard/[search_space_id]/documents/upload/page.tsx
surfsense_web/app/dashboard/[search_space_id]/documents/youtube/page.tsx
surfsense_web/app/dashboard/[search_space_id]/logs/(manage)/page.tsx
surfsense_web/app/dashboard/api-key/api-key-client.tsx
surfsense_web/app/dashboard/page.tsx
surfsense_web/app/dashboard/searchspaces/page.tsx
surfsense_web/app/login/GoogleLoginButton.tsx
surfsense_web/app/login/LocalLoginForm.tsx
surfsense_web/app/login/page.tsx
surfsense_web/app/onboard/page.tsx
surfsense_web/app/pricing/page.tsx
surfsense_web/app/register/page.tsx
surfsense_web/components/ModernHeroWithGradients.tsx
surfsense_web/components/chat/AnimatedEmptyState.tsx
surfsense_web/components/contact/contact-form.tsx
surfsense_web/components/onboard/add-provider-step.tsx
surfsense_web/components/onboard/assign-roles-step.tsx
surfsense_web/components/onboard/completion-step.tsx
surfsense_web/components/pricing.tsx
surfsense_web/components/search-space-form.tsx
surfsense_web/components/settings/llm-role-manager.tsx
surfsense_web/components/settings/model-config-manager.tsx
surfsense_web/components/theme/theme-toggle.tsx
surfsense_web/components/ui/spotlight.tsx
surfsense_web/components/ui/tilt.tsx
surfsense_web/package-lock.json
surfsense_web/package.json
surfsense_web/pnpm-lock.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant