fix(sfe): fix sfe storage issue #2629
Merged
+462
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallels the fix described for #2618. As with SFT, the storage term for SFE was not correct for standard SFR flow approach ("quasi-steady-state", meaning one steady flow solution to another that may have different flow rates and therefore a different amount of storage in each reach). Until this fix, the volume for the previous time step was calculated using the current storage flow rate, resulting in zero storage change for SFR. The SFT storage term is now calculated using the current and previous reach volumes. This change may affect existing models that use SFE.
ruffon new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.fprettify