Skip to content

Conversation

@emorway-usgs
Copy link
Contributor

Parallels the fix described for #2618. As with SFT, the storage term for SFE was not correct for standard SFR flow approach ("quasi-steady-state", meaning one steady flow solution to another that may have different flow rates and therefore a different amount of storage in each reach). Until this fix, the volume for the previous time step was calculated using the current storage flow rate, resulting in zero storage change for SFR. The SFT storage term is now calculated using the current and previous reach volumes. This change may affect existing models that use SFE.

  • Replaced section above with description of pull request
  • Related to pull request fix(sft): fix sft storage issue #2618
  • Added new test
  • Ran ruff on new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.
  • Formatted new and modified Fortran source files with fprettify
  • Added docstring comments to new and modified procedures
  • Updated develop.toml with a plain-language description of the bug fix, change, feature; required for changes that may affect users

@emorway-usgs emorway-usgs mentioned this pull request Jan 1, 2026
7 tasks
@emorway-usgs emorway-usgs merged commit c8d2e19 into MODFLOW-ORG:develop Jan 6, 2026
22 checks passed
@emorway-usgs emorway-usgs deleted the fix_sfe branch January 6, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant