-
Notifications
You must be signed in to change notification settings - Fork 7
pydantic based netcdf input schema #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
modflow_devtools/netcdf.py
Outdated
|
|
||
|
|
||
| @dataclass | ||
| class NetCDFPackageCfg: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest consistent naming of the user-facing model and package config objects, maybe dropping "Cfg" and "Input" and just calling them NetCDFModel and NetCDFPackage?
Just to mention for passersby, we discussed offline it would be nice if there were a single object model whose structure matches the schema and which exposes a template construction API via e.g. classmethods, instead of having two parallel object models, one schema, one user-facing. But I know you were still looking at the feasibility of that and it may come later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aligning the names is a good idea- I'm fine with your suggestion or suffixing both with "Input" just to clearly distinguish scope. Maybe we should chat once more about the conceptual alignment, I think things are set up to take that step and it is probably a good time to consider doing it.
|
I didn't look at the other PR against the |
MODFLOW 6 NetCDF input schema with validation interface