Skip to content

Conversation

@mjreno
Copy link
Contributor

@mjreno mjreno commented Nov 24, 2025

MODFLOW 6 NetCDF input schema with validation interface

  • validate meta dictionaries describing a NetCDF input file
  • generate jsonschema dictionaries directly from schema

@mjreno mjreno marked this pull request as draft November 24, 2025 15:43


@dataclass
class NetCDFPackageCfg:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest consistent naming of the user-facing model and package config objects, maybe dropping "Cfg" and "Input" and just calling them NetCDFModel and NetCDFPackage?

Just to mention for passersby, we discussed offline it would be nice if there were a single object model whose structure matches the schema and which exposes a template construction API via e.g. classmethods, instead of having two parallel object models, one schema, one user-facing. But I know you were still looking at the feasibility of that and it may come later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligning the names is a good idea- I'm fine with your suggestion or suffixing both with "Input" just to clearly distinguish scope. Maybe we should chat once more about the conceptual alignment, I think things are set up to take that step and it is probably a good time to consider doing it.

@wpbonelli
Copy link
Contributor

I didn't look at the other PR against the dfn branch, presumably the differences are minimal. Reviewing this one because it will be the more "public" of the two for now.

@mjreno mjreno changed the title netcdf input utilities and validation pydantic based netcdf input schema Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants