Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] improve planning to ask users for a dataset; other small fixes #30

Merged
merged 5 commits into from
May 22, 2024

Conversation

HuaizhengZhang
Copy link
Contributor

@HuaizhengZhang HuaizhengZhang commented May 21, 2024

Closes

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Do we need any specific form for testing your changes? If so, please attach one.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

Before submitting this PR, please make sure you have:

  • confirmed all checks still pass OR confirm CI build passes.
  • verified that any code or assets from external sources are properly credited in comments and/or in
    the credit file.

@HuaizhengZhang HuaizhengZhang self-assigned this May 21, 2024
@HuaizhengZhang HuaizhengZhang changed the title [WIP] [WIP] prepare csv example; improve planning; other small fixes May 21, 2024
@HuaizhengZhang HuaizhengZhang changed the title [WIP] prepare csv example; improve planning; other small fixes [WIP] improve planning; other small fixes May 22, 2024
@HuaizhengZhang HuaizhengZhang changed the title [WIP] improve planning; other small fixes [WIP] improve planning to ask users for dataset; other small fixes May 22, 2024
@HuaizhengZhang HuaizhengZhang changed the title [WIP] improve planning to ask users for dataset; other small fixes [MRG] improve planning to ask users for a dataset; other small fixes May 22, 2024
@HuaizhengZhang
Copy link
Contributor Author

as more conflicts are coming, I decide to mrg first...

@HuaizhengZhang HuaizhengZhang merged commit f43ea71 into main May 22, 2024
3 checks passed
@HuaizhengZhang HuaizhengZhang deleted the hz/csv_example branch May 22, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant