Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new video #118

Merged
merged 1 commit into from
Jul 26, 2024
Merged

add new video #118

merged 1 commit into from
Jul 26, 2024

Conversation

HuaizhengZhang
Copy link
Contributor

@HuaizhengZhang HuaizhengZhang commented Jul 26, 2024

User description

Closes #

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Do we need any specific form for testing your changes? If so, please attach one.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

Before submitting this PR, please make sure you have:

  • confirmed all checks still pass OR confirm CI build passes.
  • verified that any code or assets from external sources are properly credited in comments and/or in
    the credit file.

PR Type

documentation


Description

  • Updated the video link in the README.md file to a new URL.
  • Removed the outdated video link from the README.md file.

Changes walkthrough 📝

Relevant files
Documentation
README.md
Update video link in README.md                                                     

README.md

  • Updated video link in the documentation.
  • Removed old video link.
+1/-1     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

@HuaizhengZhang HuaizhengZhang self-assigned this Jul 26, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Jul 26, 2024
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

Copy link

github-actions bot commented Jul 26, 2024

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Enhancement
Improve hyperlink readability and accessibility by adding descriptive text

It's recommended to use a descriptive text for the hyperlink to improve
accessibility and provide context to the reader. Markdown allows you to use the
format link text to make links more readable and meaningful.

README.md [28]

-https://github.com/user-attachments/assets/dac7be90-c662-4d0d-8d3a-2bc4df9cffb9
+[New Video Tutorial](https://github.com/user-attachments/assets/dac7be90-c662-4d0d-8d3a-2bc4df9cffb9)
 
Suggestion importance[1-10]: 9

Why: The suggestion improves the readability and accessibility of the hyperlink by providing a descriptive text, which is a good practice in documentation.

9

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 26, 2024
@huangyz0918 huangyz0918 merged commit 30b6409 into main Jul 26, 2024
4 checks passed
@HuaizhengZhang HuaizhengZhang deleted the hz/video branch July 26, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer Review effort [1-5]: 1 size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants