[pull] master from facebook:master #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* Fix development mode hang when iframe is removed * Also fix #16734
taneliang
added a commit
that referenced
this pull request
Aug 17, 2020
* Add GitHub Actions workflow Adds CI workflow to run `yarn lint`, `yarn test`, and `yarn build`. `yarn flow` excluded for now as we still have many typecheck failures. Based on: - Default Node.js workflow - https://github.com/actions/cache/blob/master/examples.md#node---yarn * Prettify node.js.yml * Configure test script to pass with no tests Tests are currently failing as there are no tests in the codebase. This commit adds `--passWithNoTests` to make Jest not error. This commit should be reverted once there are tests in our codebase. * Revert "Configure test script to pass with no tests" This reverts commit bd57b9ea82328fb3765b91b7847eb99f51b7aae4. * Fix lint in new files on master
taneliang
added a commit
that referenced
this pull request
Aug 19, 2020
* Add GitHub Actions workflow Adds CI workflow to run `yarn lint`, `yarn test`, and `yarn build`. `yarn flow` excluded for now as we still have many typecheck failures. Based on: - Default Node.js workflow - https://github.com/actions/cache/blob/master/examples.md#node---yarn * Prettify node.js.yml * Configure test script to pass with no tests Tests are currently failing as there are no tests in the codebase. This commit adds `--passWithNoTests` to make Jest not error. This commit should be reverted once there are tests in our codebase. * Revert "Configure test script to pass with no tests" This reverts commit bd57b9ea82328fb3765b91b7847eb99f51b7aae4. * Fix lint in new files on master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )