[pull] master from facebook:master #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Summary: The RootView being managed by Fabric should have an id of View.NO_ID when it is "handed over" to RN. This is true for Fabric and non-Fabric and setting a custom id on the ReactRootView has never been supported. I'm temporarily (?) adding an additional check earlier and into ReactRootView to hopefully catch any of these issues early. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D26077509 fbshipit-source-id: 59e1ec080504e50698acc654c29120f039238a96
…ager.js Summary: This diff refactors the StaticViewConfigsPaperUIManager to avoid loading NativeUIManager. This is part of a experiment to prevent loading UIManagerModule class in native. changelog: [internal] Reviewed By: JoshuaGross Differential Revision: D25630215 fbshipit-source-id: 40d6f3b36ad4c3377820b1dcf0bd949db063d899
Summary: This diff removes the call to UIManager.getViewManagerConfig into the deprecatedPropType method when static view configs are enabled This was necessary to avoid innecessary calls to UIManager.getViewManagerConfig and to avoid loading UIManagerModule classes when static view configs are enabled changelog: [internal] internal Reviewed By: fkgozali, yungsters Differential Revision: D26040855 fbshipit-source-id: 82cad9f4abe9898e781fd989ebaa03497dad926b
Summary: This diff adds TextInput in the list of components that support static view configs changelog: [internal] Reviewed By: yungsters Differential Revision: D26040854 fbshipit-source-id: d6b5d3a78ef4657acf3f2c4ebe527ad4ca40bcb5
Summary: This diff avoids retrieving view configs on Text component when static view configs are enabled changelog: [interrnal] Reviewed By: JoshuaGross, sammy-SC Differential Revision: D25577278 fbshipit-source-id: 674b8067cea13d284848e35dabaf26cd1bea4e27
…ctly Summary: Before this change, `mountingOverrideDelegate` was proxied via `Scheduler::startSurface` and `ShadowTree::ShadowTree` constructor down to `MountingCordinator`. Now we set it on the `MountingCoordinator` directly. Changelog: [Internal] Fabric-specific internal change. Reviewed By: sammy-SC Differential Revision: D26049076 fbshipit-source-id: 7f1ecf2c8b6f264a7e59d19881464fe529c53d30
…on demand Summary: This changes how we access UIManagerBinding in Fabric code. Instead of storing a pointer to it and accessing it, now we just request it from JavaScript runtime on demand. After a week of testing, I hope we will be able to simplify retaining and referencing logic between UIManager and UIManagerBinding. The change is gated just in case to have the ability to turn this new implementation off. Changelog: [Internal] Fabric-specific internal change. Reviewed By: sammy-SC Differential Revision: D26082788 fbshipit-source-id: 211c551fe1aaba9b0bff18478e40e1e1f32e999c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )