Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements: Move json data variable to a json object file #38

Merged
merged 15 commits into from
Oct 14, 2024

Conversation

vantage-ola
Copy link
Member

@vantage-ola vantage-ola commented Oct 9, 2024

Instead of having json data variable in the app.py, we can move it to a json file and load it. It aims to resolve #37

@vantage-ola vantage-ola changed the title Improv: Move json data variable to a json object file Improvements: Move json data variable to a json object file Oct 9, 2024
@vantage-ola
Copy link
Member Author

@yashika51 pls review, thanks , #23 aims to fix the failing tests. thanks :)

@vantage-ola vantage-ola marked this pull request as ready for review October 9, 2024 09:33
@vantage-ola
Copy link
Member Author

vantage-ola commented Oct 9, 2024

i didnt even realise it had conflicts, its fixed now, thanks...

@yashika51
Copy link
Collaborator

i didnt even realise it had conflicts, its fixed now, thanks...

We still have some failing tests, can you check it out?

@Shopiley
Copy link
Contributor

@vantage-ola, the one linter test you're failing is because you have the name unique_resume_data_fixture as both a function name and a variable name. Try changing the function name to something else.

@vantage-ola
Copy link
Member Author

vantage-ola commented Oct 11, 2024

Ohhh 😭😭😭
Will do that in time, thanks...

i dont think that's the reason though, something that has to do with my approach... using the pytest fixtures function in the same file.... I will figure it out, thanks

@vantage-ola
Copy link
Member Author

@yashika51 good to go 😅

@yashika51
Copy link
Collaborator

@yashika51 good to go 😅

some conflicts fix to do

@vantage-ola
Copy link
Member Author

I might as well close this pr , im losing my mind already ....tchhhh

@vantage-ola
Copy link
Member Author

@yashika51 i think it's good now

@yashika51 yashika51 merged commit 2ca410d into MLH-Fellowship:main Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make data variable a json object file
3 participants