-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements: Move json data variable to a json object file #38
Improvements: Move json data variable to a json object file #38
Conversation
@yashika51 pls review, thanks , #23 aims to fix the failing tests. thanks :) |
i didnt even realise it had conflicts, its fixed now, thanks... |
We still have some failing tests, can you check it out? |
@vantage-ola, the one linter test you're failing is because you have the name |
Ohhh 😭😭😭 i dont think that's the reason though, something that has to do with my approach... using the pytest fixtures function in the same file.... I will figure it out, thanks |
@yashika51 good to go 😅 |
some conflicts fix to do |
I might as well close this pr , im losing my mind already ....tchhhh |
@yashika51 i think it's good now |
Instead of having json data variable in the
app.py
, we can move it to a json file and load it. It aims to resolve #37