Post PR 800: Update exp. shelice_remeshing code #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all local changes are within CPP #ifdef that are not defined in this experiment, hard to maintain without beeing able to check if these lines of code are still working.
But no real changes from PR #800 to import in shelfice_thermodynamics.F since the update of "kTopC" is missing in this local version.
Member
Author
|
Going to mergre this PR later today, so that this experiment will pass tomorrow regression tests that failed today. e.g., In the future, could think of removing this experiment since it relies on many customized src code that are lagging behind the standard version and did not get much new development or update since it got added there. @dngoldberg what is your view on this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since new parameter
SHI_update_kTopCwas added toSHELFICE.handshelfice_readparms.Fin PR MITgcm/MITgcm#800 , need to update local copy of these files here inshelfice_remeshing/code