Post pr714 output update #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bring GGL90_OPTIONS.h up-to-date (keeping same selection) - bring customized version of mom_calc_visc.F up-to-date (+add reference copy here just to facilitate future updates).
Update reference output of all global_oce_cs32 & llc90 tests that uses pkg/ggl90, (i.e., all except llc90 output_adm.txt & output_adm.core2.txt, where useGGL90=F.) both Fwd & Adm, after bug fixed (related to missing hFac) in pkg/ggl90. Note: Since none of these tests uses IDEMIX, could have preserved the same results by defining CCP option "GGL90_MISSING_HFAC_BUG" in GGL90_OPTIONS.h
mjlosch
approved these changes
Jun 12, 2023
Member
mjlosch
left a comment
mjlosch
left a comment
There was a problem hiding this comment.
LGTM, we might want to update GGL90_OPTIONS.h again after introducing yet another flag in pr714, but it's not really necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update reference output of experiments
global_oce_cs32andglobal_oce_llc90following bug fixed inpkg/ggl90, main repos PR MITgcm/MITgcm#714Update both Fwd & Adm ref. output, except the 2 AD tests in llc90 that do not use pkg/gg90 (primary + core2), after bug fixed (related to missing hFac) in pkg/ggl90.
Note: Since none of these tests uses IDEMIX, could have preserved the same results
by defining CCP option "GGL90_MISSING_HFAC_BUG" in GGL90_OPTIONS.h
To merge only after main repos PR MITgcm/MITgcm#714 has been merged in.