Conversation
Why these changes are being introduced: There are two uncaught edge cases in the full-text link logic: 1. Full-text options are removed when libkey links exist. 2. I a PNX record as an empty links object (rather than omitting it altogether), then full-text options will not display. Relevant ticket(s): - [USE-663](https://mitlibraries.atlassian.net/browse/USE-663) How this addresses that need: This addresses the edge cases noted above. Side effects of this change: This change was prompted by full-text links not appearing in staging, despite working properly in local development environments. It's unclear whether this change is what's required to fix staging.
❌ 4 blocking issues (4 total)
|
Coverage Report for CI Build 33194305177Coverage remained the same at 98.3%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
jazairi
marked this pull request as draft
August 28, 2026 17:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
There are two uncaught edge cases in the full-text link logic:
options will not display.
Relevant ticket(s):
How this addresses that need:
This addresses the edge cases noted above.
Side effects of this change:
This change was prompted by full-text links not
appearing in staging, despite working properly in
local development environments. It's unclear
whether this change is what's required to fix
staging.
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing