TIMX 536 537 - Update TIM for TDA v3 #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: With recent TDA updates, we no longer requiring .load() called on TIMDEXDataset. This moves some filtering into the read methods. How this addresses that need: * Remove .load() usage for TIMDEXDataset * Update read methods * Update dataset fixture to reflect new structure Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TIMX-536
ehanson8
approved these changes
Aug 15, 2025
Contributor
ehanson8
left a comment
ehanson8
left a comment
There was a problem hiding this comment.
Awesome to see how this streamlines the whole workflow!
ghukill
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
This PR updates TIM to use the new TDA v3.0 release.
Updates include:
TIMDEXDataset.load()calls.load()).load(current_records=True)toread_*(table="current_records")NOTE: this PR has a lot of lines of code changing. 99% of this is adding a
run_timestampcolumn to the fixture data, which was overlooked in previous migration work.The important changes are in
cli.pyandtest_cli.py.How can a reviewer manually see the effects of these changes?
Successful StepFunction run in Dev.
For the indexing work, TIM used an updated format to stream transformed records via TDA.
Includes new or updated dependencies?
YES
Changes expectations for external applications?
NO
What are the relevant tickets?