Skip to content

Conversation

@djanelle-mit
Copy link
Contributor

@djanelle-mit djanelle-mit commented Jun 16, 2025

Summary of changes (please refer to commit messages for full details)
As we explore interventions to be delivered to interfaces in our ecosystem, we need a consistent design pattern to deliver these interventions and call attention to them.

This work implements a design for a new "Suggestion Panel" component, which can be used for interventions as well as other types of suggestions in our products.

This work is local to TACOS for now, but will be extracted into an official design system component in the future.

Placeholder parts:

  • Color variables for the design system are defined in the _suggestion-panel.scss file for the time being and need to be extracted.
  • The current TACOS Font Awesome version is used as a placeholder. This should be replaced via the CDN / Design system version in the future.
  • The suggestion panel uses a button that needs to be extracted into it's own component.

Developer

Ticket(s)

https://mitlibraries.atlassian.net/browse/TCO-144

Accessibility

  • ANDI or Wave has been run in accordance to our guide and
    all issues introduced by these changes have been resolved or opened
    as new issues (link to those issues in the Pull Request details above)
  • There are no accessibility implications to this change

Documentation

  • Project documentation has been updated, and yard output previewed
  • No documentation changes are needed

ENV

  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.

Stakeholders

  • Stakeholder approval has been confirmed
  • Stakeholder approval is not needed

Dependencies and migrations

NO dependencies are updated

NO migrations are included

Reviewer

Code

  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.

Documentation

  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.

Testing

  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@djanelle-mit djanelle-mit requested a review from JPrevost June 16, 2025 13:56
@mitlib mitlib temporarily deployed to tacos-api-pipeline-pr-249 June 16, 2025 13:57 Inactive
@JPrevost JPrevost self-assigned this Jun 16, 2025
Copy link
Member

@JPrevost JPrevost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. The only required change is to pull out the debug line. The rest is just either comments or questions that likely don't require change at this time.

@mitlib mitlib temporarily deployed to tacos-api-pipeline-pr-249 June 16, 2025 15:03 Inactive
@djanelle-mit
Copy link
Contributor Author

@JPrevost Updated comments where needed and removed the debug line!

@djanelle-mit djanelle-mit requested a review from JPrevost June 16, 2025 15:03
@mitlib mitlib temporarily deployed to tacos-api-pipeline-pr-249 June 16, 2025 15:22 Inactive
@djanelle-mit djanelle-mit merged commit 36cdcc8 into main Jun 16, 2025
7 checks passed
@djanelle-mit djanelle-mit deleted the TCO-144 branch June 16, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants