Add faculty start date to people feed #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: For faculty, sometimes the original hire date doesn't line up with the faculty start date and that was causing problems in the OA workflow. A new fields was added to the data warehouse table that gives us the date a hire became faculty, which we want to use preferentially over the original hire date when present. How this addresses that need: * Adds DATE_TO_FACULTY field to the persons model * Retrieves DATE_TO_FACULTY field from the data warehouse as part of the person record * Adds a method to map the DATE_TO_FACULTY field as ArriveDate in the people feed XML if present, otherwise continues as before and maps the ORIGINAL_HIRE_DATE to ArriveDate * Updates tests/fixtures as needed Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/INFRA-299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates people feed to use DATE_TO_FACULTY field from the Data Warehouse if present for ArriveDate, otherwise continues to use ORIGINAL_HIRE_DATE.
Helpful background context
For faculty, sometimes the original hire date doesn't line up with the faculty start date and that was causing problems in the OA workflow. A new field was added to the data warehouse table that gives us the date a hire became faculty, which we want to use preferentially over the original hire date when present.
How can a reviewer manually see the effects of these changes?
We can't really yet because part of verification requires backend activity to happen in Symplectic Elements. However, the changes and file output have been verified locally in Docker and on Stage.
Includes new or updated dependencies?
NO
Relevant tickets
Developer
Code Reviewer