check multiple address types #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: We want to use the address specified as the payment address in alma. An address can have multiple types in alma. We were only checking the first type of each address to see if it was a payment address, so in these cases we were not correctly identifying the payment address How this addresses that need: Checks all address types for each address to determine if an address is the payment address
pinning click to version 8.1.3 because click 8.1.4 and 8.1.5 have a conflict with mypy 1.4.1 see: pallets/click#255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
We want to use the address specified as the payment address in alma. An address can have multiple types in alma. We were only checking the first type of each address to see if it was a payment address, so in these cases we were not correctly identifying the payment address
How this addresses that need:
Checks all address types for each address to determine if an address is the payment address
What does this PR do?
fixes bug where the payment address was not recognized if the address had multiple types
updates unit test
Helpful background context
an address can have multiple types in Alma. We want to use the address with the type "payment".
Includes new or updated dependencies?
YES
What are the relevant tickets?
Developer
Code Reviewer
(not just this pull request message)