-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared authorship #890
base: dev
Are you sure you want to change the base?
Shared authorship #890
Conversation
f8f7c89
to
36dcef1
Compare
Thank you for working on this, Lucas. There are still some (mostly minor) issues here, and I realize you may not have any time to work on this further before you leave, but this is a good start and I hope we can get it integrated soon. I'm following you, more or less, up to commit 2c0aa36. After that... commit 4b0419f is mostly a stylistic change that seems unrelated to the rest of this series. There are some issues (PublishedAuthor.name is wrong; there's something funky going on with text_affiliations) but in terms of style it's a definite improvement. Then we come to 36dcef1, and I have no idea what's going on and it seems to be broken. :P What is the intention here, and what is the logic? |
Although this seems like just style changes, it was necessary I could use I made it so the properties would have the exact same value as was previously assigned
So, in the first implementation, if an author was first in the group and I clicked his up button, the whole group would be moved up, changing position with the previous group/user. That was a bit confusing for the user, so instead, I introduced this change, that removes the up/down function for the first/last authors of a group. It should still be possible to move authors within their groups, which was not working but my last commit should've fixed it. |
This adds a new shared authorship functionality when submitting projects.
BaseAuthor
andPublishedAuthor
now have ashared
field, which stores a number corresponding to a group of authors that contributed equally