Fix Encoding Error When Reading TSV Files in load_custom_dataset_from_folder#132
Open
Seanium wants to merge 2 commits intoMIND-Lab:masterfrom
Open
Fix Encoding Error When Reading TSV Files in load_custom_dataset_from_folder#132Seanium wants to merge 2 commits intoMIND-Lab:masterfrom
Seanium wants to merge 2 commits intoMIND-Lab:masterfrom
Conversation
Fix Encoding Error When Reading TSV Files in load_custom_dataset_from_folder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Encoding Error When Reading TSV Files
Error Log:
Root Cause:
OCTIS attempts to read a UTF-8 encoded file (
corpus.tsv) using GBK encoding, which causes the error. The source code does not support specifying the encoding for reading files, leading to this mismatch.Solution
Modify
load_custom_dataset_from_folderto Add Encoding ParameterAdd an
encodingparameter to theload_custom_dataset_from_folderfunction, with the default set to UTF-8:Recommendation
By adding an
encodingparameter, we allow OCTIS to handle different encodings more flexibly and avoid the encoding mismatch. UTF-8 should be the default, but this solution ensures compatibility with other encodings if needed.