Adding the lowercase aspect #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslucki
reviewed
Jul 25, 2019
|
|
||
|
|
||
| class LowerCase(Aspect): | ||
| """Lower-cases the dataset. |
There was a problem hiding this comment.
Could you add the info that it's especially important for NER tasks?
aslucki
reviewed
Jul 25, 2019
| @@ -54,14 +54,17 @@ def load(self, path): | |||
| processed = self._process_sample(sample) | |||
| self._data.append(processed) | |||
|
|
|||
| def apply(self, aspect, apply_to_ne=False): | |||
| def apply(self, aspect, apply_to_ne=False, apply_to_both=False): | |||
There was a problem hiding this comment.
Maybe it would be better to rewrite it so for example there is the apply_to parameter that can take one of three values:
NON_NE, NE, BOTH? I think that when it's controlled by two variables it's a little bit confusing.
|
@lunayach You're right, it totally makes sense to add this aspect. I've tested your code and added some comments to consider. Also, sorry for the late response. Please don't hesitate to mention me or request a review, otherwise I don't receive any notifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tasks like NER, which is highly dependent on Capitalization, I think it's important to have a lowercase aspect as well. This aspect would lowercase the entire dataset. I'll be very happy to discuss any suggestions.