Skip to content

Fixed some Keccak testcases #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

danielmarschall
Copy link
Contributor

@danielmarschall danielmarschall commented May 5, 2024

This PR contains 2 fixes:

  1. It fixes a bug that was cause because an uninitialized variable LastByteLen instead of the argument LastByteLength was used.

  2. I have reverted to AddLastByteForCodeTest(lDataRow, #$13, 5); again, now the test cases do work. I still have no clue why #$13 represents the test vector 0b10011, but for some reason it works. Maybe some day someone will find out why it works :-)
    Edit 12 Feb 2025: Regarding point 2, I don't understand why I was confused back then.
    0b10011 is 0x13 and Decimal 19. In Delphi hex numbers have a $ prefix, so both #$13 and #19 are correct, but not #$19.


All test cases except the Unicode test case are working now. The Unicode test case might be impossible, though; see more details in #65

All test cases except the Unicode test case are working now. MHumm#65
@danielmarschall
Copy link
Contributor Author

  1. I am just confused where the 0b10011 (which is dec19 / hex13) comes from in the first place. Is this documented somewhere? I think this should be added as a comment somewhere, so it is easier to understand.

  2. I noticed that there is an "exit" at

    I am not sure if this is intentional or an oversight from debugging.

@MHumm What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant