Skip to content

Conversation

@MHeironimus
Copy link
Owner

This update contains changes contributed by @per1234 and @e-bonner. These update allow the library to be installed via a GitHub download or to function properly even if it is not installed in the Arduino/libraries folder. See the updated README for more details.

Includes PRs

MHeironimus and others added 12 commits February 20, 2018 18:58
* Created initial issue template file
* Created initial pull request template
A popular library installation technique is to download the library via GitHub's Clone or download > Download ZIP and then use the Arduino IDE's Sketch > Include Library > Add .ZIP Library. This requires the library to be in the root of the repository, not in a subfolder. If the library is not in the root of the repository this installation technique fails:

Specified folder/zip file does not contain a valid library

This move is also required if you wanted to add your library to the Arduino Library Manager index, which provides an even easier installation option.

After this change, the installation scripts are no longer needed. These scripts would only work with the default sketchbook location.
* Update to use new GitHub templates
* Deleting old template files.
…rduinoJoystickLibrary into community-updates

Including DynamicHID.h in Joystick.h using <> prevents it from being found if the library is not in the Arduino/libraries directory. This means that it cannot be included as part of a project and significantly increases the difficulty of using it as a git submodule where the library cannot easily be patched. Using "" should not break anything if it is installed to Arduino/libraries.
This PR simply changes the include to "".
- Reformatted README
- Use syntax highlighting for code example
- Fixed typo
…duinoJoystickLibrary into community-updates

A popular library installation technique is to download the library via GitHub's Clone or download > Download ZIP and then use the Arduino IDE's Sketch > Include Library > Add .ZIP Library. This requires the library to be in the root of the repository, not in a subfolder. If the library is not in the root of the repository this installation technique fails:
```
Specified folder/zip file does not contain a valid library
```
This move is also required if you wanted to add your library to the [Arduino Library Manager](https://github.com/arduino/Arduino/wiki/Library-Manager-FAQ) index, which provides an even easier installation option.

After this change, the installation scripts are no longer needed. These scripts would only work with the default sketchbook location.
@MHeironimus MHeironimus linked an issue Jun 30, 2020 that may be closed by this pull request
@MHeironimus MHeironimus linked an issue Jun 30, 2020 that may be closed by this pull request
@MHeironimus MHeironimus merged commit 96fab9b into version-2.0 Jun 30, 2020
@MHeironimus MHeironimus deleted the community-updates branch June 30, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Joysick Library does not contain a valid library.

4 participants