Skip to content

Fix segfault in 3D cylindrical post-process boundary conditions #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbryngelson merged 2 commits into from
Apr 6, 2026
+29 −24
Merged

Fix segfault in 3D cylindrical post-process boundary conditions #1356

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12e31ca
Fix segfault in 3D cylindrical post-process: make pb_in/mv_in optiona…
sbryngelson Apr 6, 2026
0fb4a44
Add present(pb_in/mv_in) guards to s_symmetry and s_periodic QBMM blocks
sbryngelson Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 29 additions & 24 deletions src/common/m_boundary_common.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@ contains
call s_dirichlet(q_prim_vf, 1, -1, k, l)
end select

if (qbmm .and. (.not. polytropic) .and. (bc_type(1, 1)%sf(0, k, l) <= BC_GHOST_EXTRAP)) then
if (qbmm .and. (.not. polytropic) .and. present(pb_in) .and. present(mv_in) .and. (bc_type(1, 1)%sf(0, k, &
& l) <= BC_GHOST_EXTRAP)) then
call s_qbmm_extrapolation(1, -1, k, l, pb_in, mv_in)
end if
end do
Expand Down Expand Up @@ -130,7 +131,8 @@ contains
call s_dirichlet(q_prim_vf, 1, 1, k, l)
end select

if (qbmm .and. (.not. polytropic) .and. (bc_type(1, 2)%sf(0, k, l) <= BC_GHOST_EXTRAP)) then
if (qbmm .and. (.not. polytropic) .and. present(pb_in) .and. present(mv_in) .and. (bc_type(1, 2)%sf(0, k, &
& l) <= BC_GHOST_EXTRAP)) then
call s_qbmm_extrapolation(1, 1, k, l, pb_in, mv_in)
end if
end do
Expand Down Expand Up @@ -166,8 +168,8 @@ contains
call s_dirichlet(q_prim_vf, 2, -1, k, l)
end select

if (qbmm .and. (.not. polytropic) .and. (bc_type(2, 1)%sf(k, 0, l) <= BC_GHOST_EXTRAP) .and. (bc_type(2, &
& 1)%sf(k, 0, l) /= BC_AXIS)) then
if (qbmm .and. (.not. polytropic) .and. present(pb_in) .and. present(mv_in) .and. (bc_type(2, 1)%sf(k, 0, &
& l) <= BC_GHOST_EXTRAP) .and. (bc_type(2, 1)%sf(k, 0, l) /= BC_AXIS)) then
call s_qbmm_extrapolation(2, -1, k, l, pb_in, mv_in)
end if
end do
Expand Down Expand Up @@ -196,7 +198,8 @@ contains
call s_dirichlet(q_prim_vf, 2, 1, k, l)
end select

if (qbmm .and. (.not. polytropic) .and. (bc_type(2, 2)%sf(k, 0, l) <= BC_GHOST_EXTRAP)) then
if (qbmm .and. (.not. polytropic) .and. present(pb_in) .and. present(mv_in) .and. (bc_type(2, 2)%sf(k, 0, &
& l) <= BC_GHOST_EXTRAP)) then
call s_qbmm_extrapolation(2, 1, k, l, pb_in, mv_in)
end if
end do
Expand Down Expand Up @@ -231,7 +234,8 @@ contains
call s_dirichlet(q_prim_vf, 3, -1, k, l)
end select

if (qbmm .and. (.not. polytropic) .and. (bc_type(3, 1)%sf(k, l, 0) <= BC_GHOST_EXTRAP)) then
if (qbmm .and. (.not. polytropic) .and. present(pb_in) .and. present(mv_in) .and. (bc_type(3, 1)%sf(k, l, &
& 0) <= BC_GHOST_EXTRAP)) then
call s_qbmm_extrapolation(3, -1, k, l, pb_in, mv_in)
end if
end do
Expand Down Expand Up @@ -260,7 +264,8 @@ contains
call s_dirichlet(q_prim_vf, 3, 1, k, l)
end select

if (qbmm .and. (.not. polytropic) .and. (bc_type(3, 2)%sf(k, l, 0) <= BC_GHOST_EXTRAP)) then
if (qbmm .and. (.not. polytropic) .and. present(pb_in) .and. present(mv_in) .and. (bc_type(3, 2)%sf(k, l, &
& 0) <= BC_GHOST_EXTRAP)) then
call s_qbmm_extrapolation(3, 1, k, l, pb_in, mv_in)
end if
end do
Expand Down Expand Up @@ -361,7 +366,7 @@ contains
end if
end do

if (qbmm .and. .not. polytropic) then
if (qbmm .and. .not. polytropic .and. present(pb_in) .and. present(mv_in)) then
do i = 1, nb
do q = 1, nnode
do j = 1, buff_size
Expand Down Expand Up @@ -394,7 +399,7 @@ contains
q_prim_vf(xibeg)%sf(m + j, k, l) = -q_prim_vf(xibeg)%sf(m - (j - 1), k, l)
end if
end do
if (qbmm .and. .not. polytropic) then
if (qbmm .and. .not. polytropic .and. present(pb_in) .and. present(mv_in)) then
do i = 1, nb
do q = 1, nnode
do j = 1, buff_size
Expand Down Expand Up @@ -430,7 +435,7 @@ contains
end if
end do

if (qbmm .and. .not. polytropic) then
if (qbmm .and. .not. polytropic .and. present(pb_in) .and. present(mv_in)) then
do i = 1, nb
do q = 1, nnode
do j = 1, buff_size
Expand Down Expand Up @@ -464,7 +469,7 @@ contains
end if
end do

if (qbmm .and. .not. polytropic) then
if (qbmm .and. .not. polytropic .and. present(pb_in) .and. present(mv_in)) then
do i = 1, nb
do q = 1, nnode
do j = 1, buff_size
Expand Down Expand Up @@ -500,7 +505,7 @@ contains
end if
end do

if (qbmm .and. .not. polytropic) then
if (qbmm .and. .not. polytropic .and. present(pb_in) .and. present(mv_in)) then
do i = 1, nb
do q = 1, nnode
do j = 1, buff_size
Expand Down Expand Up @@ -534,7 +539,7 @@ contains
end if
end do

if (qbmm .and. .not. polytropic) then
if (qbmm .and. .not. polytropic .and. present(pb_in) .and. present(mv_in)) then
do i = 1, nb
do q = 1, nnode
do j = 1, buff_size
Expand Down Expand Up @@ -567,7 +572,7 @@ contains
end do
end do

if (qbmm .and. .not. polytropic) then
if (qbmm .and. .not. polytropic .and. present(pb_in) .and. present(mv_in)) then
do i = 1, nb
do q = 1, nnode
do j = 1, buff_size
Expand All @@ -584,7 +589,7 @@ contains
end do
end do

if (qbmm .and. .not. polytropic) then
if (qbmm .and. .not. polytropic .and. present(pb_in) .and. present(mv_in)) then
do i = 1, nb
do q = 1, nnode
do j = 1, buff_size
Expand All @@ -603,7 +608,7 @@ contains
end do
end do

if (qbmm .and. .not. polytropic) then
if (qbmm .and. .not. polytropic .and. present(pb_in) .and. present(mv_in)) then
do i = 1, nb
do q = 1, nnode
do j = 1, buff_size
Expand All @@ -620,7 +625,7 @@ contains
end do
end do

if (qbmm .and. .not. polytropic) then
if (qbmm .and. .not. polytropic .and. present(pb_in) .and. present(mv_in)) then
do i = 1, nb
do q = 1, nnode
do j = 1, buff_size
Expand All @@ -639,7 +644,7 @@ contains
end do
end do

if (qbmm .and. .not. polytropic) then
if (qbmm .and. .not. polytropic .and. present(pb_in) .and. present(mv_in)) then
do i = 1, nb
do q = 1, nnode
do j = 1, buff_size
Expand All @@ -656,7 +661,7 @@ contains
end do
end do

if (qbmm .and. .not. polytropic) then
if (qbmm .and. .not. polytropic .and. present(pb_in) .and. present(mv_in)) then
do i = 1, nb
do q = 1, nnode
do j = 1, buff_size
Expand All @@ -675,10 +680,10 @@ contains
subroutine s_axis(q_prim_vf, pb_in, mv_in, k, l)

$:GPU_ROUTINE(parallelism='[seq]')
type(scalar_field), dimension(sys_size), intent(inout) :: q_prim_vf
real(stp), dimension(idwbuff(1)%beg:,idwbuff(2)%beg:,idwbuff(3)%beg:,1:,1:), intent(inout) :: pb_in, mv_in
integer, intent(in) :: k, l
integer :: j, q, i
type(scalar_field), dimension(sys_size), intent(inout) :: q_prim_vf
real(stp), dimension(idwbuff(1)%beg:,idwbuff(2)%beg:,idwbuff(3)%beg:,1:,1:), optional, intent(inout) :: pb_in, mv_in
integer, intent(in) :: k, l
integer :: j, q, i

do j = 1, buff_size
if (z_cc(l) < pi) then
Expand Down Expand Up @@ -708,7 +713,7 @@ contains
end if
end do

if (qbmm .and. .not. polytropic) then
if (qbmm .and. .not. polytropic .and. present(pb_in) .and. present(mv_in)) then
do i = 1, nb
do q = 1, nnode
do j = 1, buff_size
Expand Down
Loading