Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mol2 bugfix for #2318 #2319

Merged
merged 11 commits into from
Aug 8, 2019
Merged

mol2 bugfix for #2318 #2319

merged 11 commits into from
Aug 8, 2019

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Aug 7, 2019

Fixes #2318

Changes made in this Pull Request:

  • Ignore MOL2 status bit strings if present

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Copy link
Member

@richardjgowers richardjgowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @RMeli

Would it be possible to do the slice trick to reduce the number of lines to maintain?

Also CHANGELOG please

RMeli added 3 commits August 7, 2019 13:51
slice to correct length instead of try/catch exception
@RMeli
Copy link
Member Author

RMeli commented Aug 7, 2019

I confused the CHANGELOG for the documentation, sorry.

I applied the changes requested and updated the CHANGELOG.

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@165d2e4). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2319   +/-   ##
==========================================
  Coverage           ?   89.62%           
==========================================
  Files              ?      173           
  Lines              ?    21517           
  Branches           ?     2803           
==========================================
  Hits               ?    19284           
  Misses             ?     1633           
  Partials           ?      600
Impacted Files Coverage Δ
package/MDAnalysis/coordinates/MOL2.py 93.33% <100%> (ø)
package/MDAnalysis/topology/MOL2Parser.py 95% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 165d2e4...1a04741. Read the comment docs.

@orbeckst orbeckst merged commit e071ef4 into MDAnalysis:develop Aug 8, 2019
@orbeckst
Copy link
Member

orbeckst commented Aug 8, 2019

@RMeli congratulations to your first contribution in MDAnalysis. I'll also send you a GitHub invite to be added as a contributor.

@RMeli
Copy link
Member Author

RMeli commented Aug 8, 2019

Thanks @orbeckst, it was a pleasure! Hopefully it's just the first of many! =)

@RMeli RMeli deleted the bugfix/mol2 branch August 13, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MOL2 parser fails with status bits
3 participants