-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mol2 bugfix for #2318 #2319
mol2 bugfix for #2318 #2319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix @RMeli
Would it be possible to do the slice trick to reduce the number of lines to maintain?
Also CHANGELOG please
slice to correct length instead of try/catch exception
I confused the CHANGELOG for the documentation, sorry. I applied the changes requested and updated the CHANGELOG. |
Codecov Report
@@ Coverage Diff @@
## develop #2319 +/- ##
==========================================
Coverage ? 89.62%
==========================================
Files ? 173
Lines ? 21517
Branches ? 2803
==========================================
Hits ? 19284
Misses ? 1633
Partials ? 600
Continue to review full report at Codecov.
|
@RMeli congratulations to your first contribution in MDAnalysis. I'll also send you a GitHub invite to be added as a contributor. |
Thanks @orbeckst, it was a pleasure! Hopefully it's just the first of many! =) |
Fixes #2318
Changes made in this Pull Request:
PR Checklist