Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to versioningit #53

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Switch to versioningit #53

merged 3 commits into from
Nov 9, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Nov 9, 2023

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov Codecov
Copy link

codecov bot commented Nov 9, 2023 •
edited
Loading

Codecov Report

Merging #53 (c13f60b) into main (b47ed65) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@IAlibay IAlibay mentioned this pull request Nov 9, 2023
Merged
4 tasks
@orbeckst
Copy link
Member

orbeckst commented Nov 9, 2023

@ianmkenney can you please review?

ianmkenney
ianmkenney approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@ianmkenney ianmkenney left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know very little about this tool, but it appears to do what is advertised on a local install. Edit: and the changes seem consistent with the versioningit documentation and seem to make sense.

@IAlibay IAlibay merged commit d6bd97b into main Nov 9, 2023
24 checks passed
@IAlibay IAlibay deleted the bump_versioneer branch November 9, 2023 19:09
@IAlibay
Copy link
Member Author

IAlibay commented Nov 9, 2023

thanks @ianmkenney - FYI versioningit is the new recommended mdakits tool for versioning, so we might see a few more migrations later on (this is particularly important for Cython packages because versioneer is starting to lag behind quite a bit here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianmkenney ianmkenney ianmkenney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IAlibay @orbeckst @ianmkenney