Platform #54
Closed
Platform #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…USARTROUTEA was simply not correctly coded. Also, handling of true not to C standards (anything not false is true).
which means that one can swop pins without destroying other pin definitions
… 3rd argument to Serial.begin() specifying the swap set to be used.
…se for Serial. Should be invoked ahead of begin(). Avoids all the problems of the swap(), and is also compatible with the ESP8266.
…sed. It needs to be invoked before the begin(). The TX and RX pin, or only the TX pin need to be specified. This method is in tune with other Arduino classes, and is also compatible with the ESP8266. It avoids all the ugliness and conceptual bugs of the swap().
we keep the global pin definitions MISO,SCK,MOSI,SS. The 48 pin variant has 3 different pin sets, the UNO has 1 and the others have 2.
natural and also more related to the TX,RX sequence for Serial.
commit eba45bc34c03ba84b6df907dcb739155d550aacb that really solves nothing other than adding complexity.
…E_bm reflecting whether the transmit buffer is empty or not. Before this, half the time, the code did, half the time it did not.
…n there is a return statement in the block, so we can remove the unsightly loop control variable.
See also MCUdude#34
Needs to be verified
The little change to routing actually saved 24 bytes of code, so totally worth it
There may be some errors in this merge, to be investigated. Conflicts: README.md megaavr/cores/coreX-corefiles/UART.cpp megaavr/cores/coreX-corefiles/UART.h megaavr/cores/coreX-corefiles/UART_private.h megaavr/cores/coreX-corefiles/api/HardwareSerial.h megaavr/libraries/Wire/keywords.txt megaavr/libraries/Wire/src/Wire.cpp megaavr/libraries/Wire/src/Wire.h megaavr/libraries/Wire/src/utility/twi.c megaavr/platform.txt
so that the value 0 is to LOW, the value 255 is HIGH, and any value inbetween is a corresponding PWM pulse. The prevous behaviour was that the range was 0 to 256, which is not in accordance to the Arduino standard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the path for avrdude is incorrect. I believe the previous {path} thing worked for me before, but suddenly it stopped working. I believe this change makes it right.
Also, I am not sure if tools.avrdude.path is really used anywhere, but I have left it in nontheless.