In Redirector, it causes HORIZONTAL_FACING for chests or Direction.Plane.HORIZONTAL to have DOWN property

[TelepathicGrunt]

Specific mod for which you open this issue

redirector-5.0.0.jar

MC version & mod version & loader version

1.20.1, Forge

Latest log

No response

Steps to reproduce your issue

I am the dev of Repurposed Structures and I got an issue report that seemed literally physically impossible with my code:
TelepathicGrunt/RepurposedStructures#358

A friend pointed out that the user was using Redirector and that the mod is known to blow up so many other mods. I remember being told how Redirector caches the enum list behind values by avoiding the clone call with caching.

When one does this code

var a1 = Foo.values();
a1[0] = a1[1];
var a2 = Foo.values();

in normal Java, a1 and a2 will not be the same because the array was cloned. With Redirector on, this is no longer the case and a2 will be exactly a1. Which is a big problem as this is not the expectations of values and will block up many mods that were lying on values cloning. I am not sure if this specifically is why Redirector blew up up mod.

If it is not the caching, then it is probably this mixin that is allowing DOWN to pass through to the Chest's HORIZONTAL_FACING property but wouldn't explain the error message.
https://github.com/MCTeamPotato/Redirector/blob/retro-1.20.1/common/src/main/java/com/teampotato/redirector/mixin/net/minecraft/world/level/block/state/properties/DirectionPropertyMixin.java

Something in Redirector is causing this issue with my mod and I feel it boils down to assumptions that Redirector made that are fundamentally untrue or unsafe.

[Ecdcaeb]

No? This version of redirector patches the enum reference manually. Your mod code will not be patched, unless you means 5.0 for forge.

[TelepathicGrunt]

This version of redirector still has many mixins that directly replace the values call with a cache list.
https://github.com/MCTeamPotato/Redirector/blob/retro-1.20.1/common/src/main/java/com/teampotato/redirector/mixin/net/minecraft/world/entity/monster/ShulkerMixin.java

And given mods can mixin into code and such, I would really not trust caching the list and I strongly doubt these enums values are an actual bottleneck of the game. (Especially several of the mixins are targeting spots that only run a few times ever) Profiling the game and finding real hotspots of the game to optimize would be better and give better results.

But nevertheless, I had this DOWN issue in direction horizontal come up a few times before and Redirector was the cause. So somewhere or something in Redirector is allowing the wrong direction into Direction Horizontal somehow and I really don’t want to dig more into this anymore

[TelepathicGrunt]

The user was indeed using redirector-5.0.0.jar as per their modlist. Is this not the issue report repo for that version of redirector for 1.20.1 Forge?

[Ecdcaeb]

No, it is. But your reference is not true.

[Ecdcaeb]

Check the mordern-forge branch instead.

[Ecdcaeb]

You could encourage the use the version 4.x if this is a serious issue.

[KxttyKxt]

I had this issue in a modpack with the Canary mod also enabled. Disabling Canary made the DirectionProperty issue cease. Good to know this issue could be around Redirector itself, though.