-
Notifications
You must be signed in to change notification settings - Fork 32
GH-826 zero-hop as default neighborhood-mode #748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 14
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| _db_password_opt: &Option<String>, | ||
| ) -> Option<(String, UiSetupResponseValueStatus)> { | ||
| Some(("standard".to_string(), Default)) | ||
| Some(("zero-hop".to_string(), Default)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Default neighborhood-mode mismatch between UI and runtime
The setup reporter's computed_default returns "zero-hop" as the default for neighborhood-mode, but the actual configuration logic in unprivileged_parse_args_configuration.rs (line 307-309) defaults to standard mode when no value is provided. This creates a mismatch where the UI displays "zero-hop" as the default, but the node actually runs in standard mode by default, misleading users about the actual behavior.
|
Note to @kauri-hero and others: Changing a default is a serious matter. People build things on top of infrastructure based on assumptions about that infrastructure's defaults. When those defaults change, the things break. Before this is merged into master, it should be proclaimed from the rooftops that a default is changing, and anyone who doesn't want their Nodes coming up in Zero-Hop Mode needs to specify Standard Mode ASAP. Also, we might want to think about changing the name of Standard Mode. A default that isn't standard--or a standard that isn't default--is kind of a contradiction in terms; it's confusing. |
|
Thanks Dan - I totally understand and appreciate the significance of changing these defaults. |
Note
Switch default
neighborhood-modefromstandardtozero-hopand update tests/expectations accordingly.NeighborhoodModecomputed default tozero-hopinnode/src/daemon/setup_reporter.rs.neighborhood-mode=zero-hop, including setup output assertions and default setup clusters.Written by Cursor Bugbot for commit c187458. This will update automatically on new commits. Configure here.