Skip to content

Conversation

@czarte
Copy link
Collaborator

@czarte czarte commented Nov 20, 2025

Note

Switch default neighborhood-mode from standard to zero-hop and update tests/expectations accordingly.

  • Config/Setup:
    • Change NeighborhoodMode computed default to zero-hop in node/src/daemon/setup_reporter.rs.
  • Tests:
    • Update integration and unit tests to expect neighborhood-mode = zero-hop, including setup output assertions and default setup clusters.

Written by Cursor Bugbot for commit c187458. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on December 14

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

_db_password_opt: &Option<String>,
) -> Option<(String, UiSetupResponseValueStatus)> {
Some(("standard".to_string(), Default))
Some(("zero-hop".to_string(), Default))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Default neighborhood-mode mismatch between UI and runtime

The setup reporter's computed_default returns "zero-hop" as the default for neighborhood-mode, but the actual configuration logic in unprivileged_parse_args_configuration.rs (line 307-309) defaults to standard mode when no value is provided. This creates a mismatch where the UI displays "zero-hop" as the default, but the node actually runs in standard mode by default, misleading users about the actual behavior.

Fix in Cursor Fix in Web

@dnwiebe
Copy link
Collaborator

dnwiebe commented Nov 20, 2025

Note to @kauri-hero and others:

Changing a default is a serious matter. People build things on top of infrastructure based on assumptions about that infrastructure's defaults. When those defaults change, the things break. Before this is merged into master, it should be proclaimed from the rooftops that a default is changing, and anyone who doesn't want their Nodes coming up in Zero-Hop Mode needs to specify Standard Mode ASAP.

Also, we might want to think about changing the name of Standard Mode. A default that isn't standard--or a standard that isn't default--is kind of a contradiction in terms; it's confusing.

Copy link
Contributor

Thanks Dan - I totally understand and appreciate the significance of changing these defaults.
I'll ensure that we have an immediate announcement and also include several notification areas in our guides and setup instructions.
I am aware that most of the users who are using MASQ will not be starting up Node with default values in 99% of cases - especially since the previous default values for chain and rate-packs etc were far from a usable set of default values in the "real-world" live mainnet environment. So every user was having to change the defaults, either using the daemon, config file, or most commonly within the apps we provide where it's taken care of by the user easily without manual config.

But overall, point taken and we will ensure its over-communicated on this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants