GH-606: Sweeping for ending the first stage #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
utkarshg6
reviewed
Sep 16, 2025
utkarshg6
reviewed
Sep 16, 2025
utkarshg6
reviewed
Sep 16, 2025
| high_bytes, low_bytes, | ||
| )), | ||
| last_paid_timestamp: utils::from_unix_timestamp(last_paid_timestamp), | ||
| pending_payable_opt: None, |
Collaborator
There was a problem hiding this comment.
If this field is of no use, maybe remove it completely.
Contributor
Author
There was a problem hiding this comment.
Will be done in a different card.
utkarshg6
reviewed
Sep 16, 2025
| //descriptor | ||
| pub const CENTRAL_DELIMITER: char = '@'; | ||
| pub const CHAIN_IDENTIFIER_DELIMITER: char = ':'; | ||
| pub const DEFAULT_GAS_PRICE: u64 = 1; //TODO ?? Really |
Collaborator
There was a problem hiding this comment.
This should go away and wherever the constant is being used too.
Contributor
Author
There was a problem hiding this comment.
I've created a card addressing a removal of the gas-price parameter from the user interface and replacement by gas-price-margin instead.
utkarshg6
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.