Conversation
bertllll
commented
Apr 2, 2024
node/Cargo.toml
Outdated
| futures = "0.1.31" | ||
| heck = "0.3.3" | ||
| http = "0.2.5" | ||
| http = "0.1.21" |
Contributor
Author
There was a problem hiding this comment.
Hmm. I should revert this.
utkarshg6
requested changes
Apr 2, 2024
| } | ||
|
|
||
| pub fn is_test_generated_data_allowed_to_escape_project_dir() -> bool { | ||
| is_env_variable_set("ALLOW_TEST_DATA_ESCAPE_PROJECT_DIR", "true") |
Collaborator
There was a problem hiding this comment.
Let's pour some more ideas if we can find a way around this.
node/Cargo.toml
Outdated
| futures = "0.1.31" | ||
| heck = "0.3.3" | ||
| http = "0.2.5" | ||
| http = "0.1.21" |
| @@ -2048,19 +2050,16 @@ mod tests { | |||
| #[test] | |||
| fn get_modified_setup_tilde_in_config_file_path() { | |||
Collaborator
There was a problem hiding this comment.
I'm glad that you discovered this. Just my personal opinion, I'd be afraid of an application creating files in my computer outside the project directory.
A possible solution: Maybe use container provided by Docker.
utkarshg6
approved these changes
Apr 3, 2024
| let _guard = EnvironmentGuard::new(); | ||
| let _clap_guard = ClapGuard::new(); | ||
| let home_dir = ensure_node_home_directory_exists( | ||
| let node_home_dir = ensure_node_home_directory_exists( |
Collaborator
There was a problem hiding this comment.
I'd prefer home_dir. Also, let's change the function name to also say, ensure_home_directory_exists.
node/src/test_utils/mod.rs
Outdated
| pub data: Vec<u8>, | ||
| } | ||
|
|
||
| pub fn make_node_base_dir_and_return_its_absolute_and_relative_path_to_os_home_dir( |
Collaborator
There was a problem hiding this comment.
You mentioned that "why it still exists?". I think you'd like to remove it and change the code inside tests if it's used there. Good Luck 👍
masqrauder
pushed a commit
that referenced
this pull request
Apr 21, 2024
* GH-781: experimenting with a test utility * GH-781: task might be complete now * GH-781: debugging for windows * GH-781: trying to satisfy Win * GH-781: clippy * GH-781: removed bad solution for issue that now a new card was written for * GH-781: cargo.toml change * GH-781: review answered --------- Co-authored-by: Bert <Bert@Bert.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.