Skip to content

Validation changed to take place within StartOperations #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ametsapelto wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Validation changed to take place within StartOperations #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions MFiles.VAF.Extensions/ConfigurableVaultApplicationBase.ConfigurationUpdated.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,27 +68,5 @@ protected override void OnConfigurationUpdated(TSecureConfiguration oldConfigura
{
get => base.ConfManager;
}

/// <inheritdoc />
public override void StartOperations(Vault vaultPersistent)
{
// Do we have a valid configuration?
this.isCurrentConfigurationValid = this.IsValid(vaultPersistent);

// Initialize the application.
base.StartOperations(vaultPersistent);

// Ensure that our recurring configuration is updated.
try
{
this.RecurringOperationConfigurationManager?.PopulateFromConfiguration(isVaultStartup: true);
}
catch(Exception e)
{
this.Logger?.Fatal(e, $"Exception mapping configuration to recurring operations.");
}


}
}
}
11 changes: 11 additions & 0 deletions MFiles.VAF.Extensions/ConfigurableVaultApplicationBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,23 @@ protected TaskQueueBackgroundOperationManager<TSecureConfiguration> TaskQueueBac
protected override void StartApplication()
{
this.startApplicationCalled = true;
this.isCurrentConfigurationValid = this.IsValid( this.PermanentVault );
this.RecurringOperationConfigurationManager = new RecurringOperationConfigurationManager<TSecureConfiguration>(this);
this.ApplicationOverviewDashboardContentRenderer = this.GetApplicationOverviewDashboardContentRenderer();
this.AsynchronousDashboardContentRenderer = this.GetAsynchronousDashboardContentRenderer();
this.AsynchronousDashboardContentProviders.AddRange(this.GetAsynchronousDashboardContentProviders());
this.LoggingDashboardContentRenderer = this.GetLoggingDashboardContentRenderer();

// Ensure that our recurring configuration is updated.
try
{
this.RecurringOperationConfigurationManager?.PopulateFromConfiguration(isVaultStartup: true);
}
catch(Exception e)
{
this.Logger?.Fatal(e, $"Exception mapping configuration to recurring operations.");
}

#if DEBUG
// In debug builds we want to show the referenced assemblies and the like.
{
Expand Down
Loading