feat: add AI response content monitoring service #85
+754
−386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 16, 2025 23:50
- Rename TaskDecomposer.ts to taskDecomposer.ts to match import statement - Fix TypeScript compilation error TS1261 about case-sensitive file naming
yorkie
requested changes
Jun 17, 2025
lib/runtime2/threepio/capabilities/generate-domcument/RequestFlowManager.ts
Outdated
Show resolved
Hide resolved
lib/runtime2/threepio/capabilities/generate-domcument/RequestFlowManager.ts
Outdated
Show resolved
Hide resolved
|
另外，从最终统计的数据，并没有针对间隔的 DOM 操作的时间间隔进行统计 |
yorkie
reviewed
Jun 24, 2025
yorkie
requested changes
Jun 25, 2025
| export type SpanContext = TraceOptions & { | ||
| name: string, | ||
| traceType: TraceType, | ||
| metadata?: Record<string, any> |
lib/runtime2/threepio/capabilities/generate-domcument/parsers/interface.ts
Outdated
Show resolved
Hide resolved
yorkie
requested changes
Jun 25, 2025
yorkie
reviewed
Jun 26, 2025
| metadata?: Record<string, any> | ||
| }; | ||
|
|
||
| export class TaskFlowSpan implements Span { |
There was a problem hiding this comment.
为什么 Span 是 Interface，startTime 和 endTime 相关的逻辑都应该实现在 Span，而 TaskFlowSpan 只需要和 TaskFlow 直接相关的部分。
yorkie
reviewed
Jun 26, 2025
| this.start(); | ||
| } | ||
|
|
||
| public metric(key: string, value: any) { |
yorkie
reviewed
Jun 26, 2025
| this.errorInfo = err; | ||
| } | ||
|
|
||
| public start() { |
yorkie
reviewed
Jun 26, 2025
| this.metrics[key] = value; | ||
| } | ||
|
|
||
| public error(err: Error) { |
There was a problem hiding this comment.
Suggested change
| public error(err: Error) { | |
| public reportError(err: Error) { |
yorkie
reviewed
Jun 26, 2025
|
|
||
| export class TaskFlowSpan implements Span { | ||
| public metrics: Record<string, any> = {}; | ||
| public errorInfo: Error | null = null; |
There was a problem hiding this comment.
这里是否要考虑是 errors 而不是一个，因为在一段时间内，可以报多个错误
yorkie
reviewed
Jun 26, 2025
| } | ||
| } | ||
|
|
||
| public addTimePointId(timePointId: string) { |
There was a problem hiding this comment.
现在 Timepoint 和 Span 的关系到底是怎么样的呢？
There was a problem hiding this comment.
感觉可以 Span 的 startTime/endTime 变成 startPoint/endPoint
yorkie
reviewed
Jun 26, 2025
| time: number; | ||
| id: string; | ||
| referenceId: string; | ||
| static counter: number = 0; |
There was a problem hiding this comment.
Suggested change
| static counter: number = 0; | |
| static Counter: number = 0; |
静态成员需要大写
yorkie
reviewed
Jun 26, 2025
| this.type = options.type; | ||
| this.time = options.time; | ||
| this.referenceId = options.requestId; | ||
| this.id = (TimePoint.counter++).toString(); |
yorkie
reviewed
Jun 26, 2025
|
|
||
| interface CallNode { | ||
| requestId: string; | ||
| TaskFlowSpan: TaskFlowSpan[]; |
There was a problem hiding this comment.
Suggested change
| TaskFlowSpan: TaskFlowSpan[]; | |
| span: TaskFlowSpan[]; |
另外，CallNode 应该直接依赖 Span 吧？还有这里为什么是一个数组？
yorkie
reviewed
Jun 26, 2025
| children: CallNode[]; | ||
| } | ||
| export class TraceManager { | ||
| #callGragh: CallNode[] = []; |
There was a problem hiding this comment.
Suggested change
| #callGragh: CallNode[] = []; | |
| #callGraghs: CallNode[] = []; |
这里一个 callGraph 代表的是一次 call 吧？
yorkie
reviewed
Jun 26, 2025
| * define the trace options | ||
| */ | ||
| export type TraceOptions = { | ||
| requestId?: string; |
There was a problem hiding this comment.
request 是 trace 的概念还是 generate-html 内的概念呢？
yorkie
reviewed
Jun 26, 2025
| * @description | ||
| * TraceGenerateDomType is a subset of TraceType. | ||
| * */ | ||
| export type TraceType = TraceGenerateDomType; |
There was a problem hiding this comment.
全局的 TraceType 需要和 GenerateDom 解藕
yorkie
reviewed
Jun 26, 2025
| try { | ||
| for await (const sourceChunk of sourceStream) { | ||
| if (sourceChunk.type === 'text') { | ||
| for (const processedLine of jsonlProcessor.processChunk(sourceChunk.text)) { | ||
| if (isDebugging) { | ||
| reportThreepioInfo('Processing text chunk', sourceChunk.text, 'requestId', requestId); |
added 2 commits
June 27, 2025 18:00
yorkie
requested changes
Jun 27, 2025
lib/runtime2/threepio/trace/Span.ts
Outdated
| context: SpanContext, | ||
| }; | ||
|
|
||
| export class SpanImp implements Span { |
lib/runtime2/threepio/trace/Span.ts
Outdated
| startTime: this.startPoint, | ||
| endTime: this.endPoint, | ||
| errorInfo: this.errorInfo, | ||
| } |
| time: this.time, | ||
| id: this.id, | ||
| referenceId: this.referenceId, | ||
| } |
| parentRequestId: input, | ||
| requestId: input, | ||
| plannerParser: new StreamPlannerParser() | ||
| }) |
yorkie
reviewed
Jun 27, 2025
| }, async (span) => { | ||
| span.setAttributes({ systemPrompt, ...plannerParam }); | ||
| await this.#processPlannerStream({ requestId, parentRequestId: input, ...plannerParam }, plannerItemStream); | ||
| }) |
yorkie
reviewed
Jun 27, 2025
| fragmentType: FragmentType; // Type of fragment to generate | ||
| moudle: ParsedModule; // Module information | ||
| input: string, | ||
| systemPrompt: string |
There was a problem hiding this comment.
Suggested change
| systemPrompt: string | |
| systemPrompt: string, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.