Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an optional adapter layer in
sof-txthat bridges livesofplugin events intoRecentBlockhashProviderandLeaderProvider.This closes the integration gap between observer runtime signals and tx submission routing without forcing
sofas a default dependency for all SDK users.Changes
crates/sof-tx/Cargo.tomlsof-adaptersfeature.sof.crates/sof-tx/src/lib.rsadaptersmodule behindsof-adaptersfeature flag.crates/sof-tx/src/adapters/mod.rscrates/sof-tx/src/adapters/plugin_host.rsPluginHostTxProviderAdapter+PluginHostTxProviderAdapterConfig.ObserverPlugin,RecentBlockhashProvider, andLeaderProvider.prime_from_plugin_host(...)set_leader_tpu_addr(...)remove_leader_tpu_addr(...)crates/sof-tx/README.mdsof-adaptersfeature.PluginHostTxProviderAdapter.For slice-related changes, include:
sof-txcrate only).Motivation
Business motivation:
sof-tx+sofcomposition practical for latency-sensitive users without custom glue code.Technical motivation:
Alternative approaches considered:
sof-txtosof(rejected to preserve lightweight default SDK footprint).Scope and impact
sof-observerinternals unchanged).sof-adaptersfeature.Testing
Commands/results:
Both commands passed.
Related issues and documentation
docs/architecture/README.mddocs/architecture/adr/0006-transaction-sdk-and-dual-submit-routing.mdReviewer checklist
docs/architecture/ard/0003-slice-dependency-contracts.md)Additional notes
PluginHostTxProviderAdapteris intentionally feature-gated so RPC-onlysof-txusers keep the current dependency surface.