test: test if a user is created on first connection

package.json

@@ -35,6 +35,7 @@
   },
   "devDependencies": {
     "@types/chai": "^4.2.7",
+    "@types/chai-things": "0.0.34",
     "@types/express": "^4.17.2",
     "@types/hapi__joi": "^16.0.6",
     "@types/mocha": "^5.2.7",
@@ -45,6 +46,7 @@
     "@types/socket.io-client": "^1.4.32",
     "@types/uuid": "^3.4.6",
     "chai": "^4.2.0",
+    "chai-things": "^0.2.0",
     "concurrently": "^5.0.2",
     "heroku": "^7.36.2",
     "husky": "^4.0.10",

src/socket.io/socket.spec.ts

@@ -1,6 +1,9 @@
 import ioClient from 'socket.io-client'
 import io from 'socket.io'
-import { expect } from 'chai'
+import { default as chai, expect } from 'chai'
+import chaiThings from 'chai-things'
+chai.should()
+chai.use(chaiThings)
 
 import { MockLogger } from '../shared/index'
 import { Socket } from './socket'
@@ -45,6 +48,16 @@ describe('Server', () => {
             done()
           })
         })
+        it('should create a new user', () => {
+          new Promise(resolve => client.on('connect', resolve))
+            .then(() => {
+              const logs = mockLogger.getInfoLogs()
+              logs.should.include.something.that.have.string(
+                'New user created for socket'
+              )
+            })
+            .then(() => client.disconnect())
+        })
       })
 
       describe('update-user-name', () => {
@@ -84,11 +97,8 @@ describe('Server', () => {
             ),
           ])
             .then(() => {
-              const errorLogs = mockLogger.getErrorLogs()
-              expect(errorLogs).to.have.length(0)
-              const infoLogs = mockLogger.getInfoLogs()
-              expect(infoLogs).to.have.length(1)
-              expect(infoLogs[0]).to.equal(
+              const logs = mockLogger.getInfoLogs()
+              logs.should.include.something.that.equals(
                 `User name could not be updated - Parameter <Object>.${expectedParameter} is required`
               )
               done()

src/socket.io/socket.ts

@@ -115,6 +115,7 @@ class Socket {
     if (user === undefined) {
       const newUser = new User(id)
       this.users.set(id, newUser)
+      this.log.info(`getOrCreateUser`, `New user created for socket ${id}`)
       return newUser
     }
     return user