refactor: connection -> connect to stick to Socket.io doc

and also fix a log message when user is created

src/domain/events/toserver/connect.event.spec.ts

@@ -0,0 +1,10 @@
+import { expect } from 'chai'
+import { ConnectEvent } from './connect.event'
+
+describe('Events', () => {
+  describe('ConnectEvent', () => {
+    it("should have 'connect' event as name", () => {
+      expect(ConnectEvent.eventName).to.equal('connect')
+    })
+  })
+})

src/domain/events/toserver/connect.event.ts

@@ -0,0 +1,5 @@
+import { EventToServer } from './event.to.server'
+
+export class ConnectEvent {
+  static readonly eventName: string = EventToServer.Connect
+}

src/domain/events/toserver/event.to.server.ts

@@ -1,5 +1,5 @@
 export class EventToServer {
-  static readonly Connection = 'connection'
+  static readonly Connect = 'connect'
   // static readonly Disconnection = 'disconnection'
 
   // static readonly JoinRoom = 'join-room'

src/domain/events/toserver/index.ts

@@ -1,4 +1,4 @@
-export * from './connection.event'
+export * from './connect.event'
 // export * from './disconnection.event'
 
 // export * from './join.room.event'

src/socket.io/socket.spec.ts

@@ -66,7 +66,7 @@ describe('Server', () => {
           mockLogger
             .getInfoLogs()
             .should.include.something.that.have.string(
-              'New user created for socket'
+              'New user created (client socket'
             )
         })
         it('should send the ordered list of users, and their id should correspond to client sockets ids', async () => {

src/socket.io/socket.ts

@@ -2,7 +2,7 @@ import Automerge from 'automerge'
 import { Constants } from './constants'
 import { Guard, ConsoleLogger } from '../shared/index'
 import {
-  ConnectionEvent,
+  ConnectEvent,
   UpdateStateEvent,
   UpdateUserNameEvent,
   UpdateUserColorEvent,
@@ -19,7 +19,7 @@ class Socket {
   public connect() {
     this.io
       .of('/occupapp-beta')
-      .on(ConnectionEvent.eventName, (socket: SocketIOClient.Socket) => {
+      .on(ConnectEvent.eventName, (socket: SocketIOClient.Socket) => {
         // Note that a new socket (and this socket.id) is created on each
         // connection. There is no persistence for a same user between
         // connections
@@ -133,7 +133,7 @@ class Socket {
   private createUser = (id: SocketIOClient.Socket['id']): User => {
     const newUser = new User(id)
     this.users.set(id, newUser)
-    this.log.info(`getOrCreateUser`, `New user created for socket ${id}`)
+    this.log.info(`createUser`, `New user created (client socket ${id})`)
     return newUser
   }